Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for LLDP docker to support multi-npu platforms #4530

Merged
merged 3 commits into from
May 11, 2020

Commits on May 6, 2020

  1. Changes for LLDP for Multi NPU Platoforms:-

    a) Enable LLDP for Host namespace for Management Port
    b) Make sure Management IP is avaliable in per asic namespace
       needed for LLDP Chassis configuration
    c) Make sure chassis mac-address is correct in per asic namespace
    d) Do not run lldp on eth0 of per asic namespace and avoid chassis
       configuration for same
    e) Use Linux hostname instead from Device Metadata for lldp chassis
       configuration since in multi-npu platforms device metadata hostname
       will be differnt
    
    Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
    abdosi committed May 6, 2020
    Configuration menu
    Copy the full SHA
    60aa5c5 View commit details
    Browse the repository at this point in the history
  2. Address Review Comment with following changes:

    a) Use Device Metadata hostname even in per namespace conatiner.
       updated minigraph parsing for same to have hostname as system
       hostname and add new key for asic name
    
    b) Minigraph changes to have MGMT_INTERFACE Key in per asic/namespace
       config also as needed for LLDP for setting chassis management IP.
    
    Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
    abdosi committed May 6, 2020
    Configuration menu
    Copy the full SHA
    f1bc3eb View commit details
    Browse the repository at this point in the history

Commits on May 10, 2020

  1. Address Review Comments

    abdosi committed May 10, 2020
    Configuration menu
    Copy the full SHA
    358b2e4 View commit details
    Browse the repository at this point in the history