Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lldpmgrd] To change error log condition in is_port_up() #4606

Merged
merged 2 commits into from
May 19, 2020

Conversation

chenkelly
Copy link
Contributor

@chenkelly chenkelly commented May 15, 2020

- Why I did it
For lldpmgrd, listen for changes to the PORT table in the CONFIG_DB and APP_DB
To handle alias/description config change.
To check if port is up or down by looking into the oper-status for the port in PORT TABLE in the App DB.
Don't find it in the App DB, will log error.
During initializing, it is possible that port change in CONFIG_DB and not ready in APP_DB.
When we executed test_mgmtvrf.py::TestReboot::test_reboot case, it cannot pass due to LogAnalyzerError.

Apr 29 03:28:18.447385 as7726-32x-1 INFO lldp#lldpmgrd: Starting up...
Apr 29 03:28:18.451707 as7726-32x-1 ERR lldp#lldpmgrd: Port 'Ethernet8' not found in PORT_TABLE table in App DBApr 29 03:28:18.682655 as7726-32x-1 INFO swss#supervisord: start.sh portmgrd: started
.....
Apr 29 03:28:18.772995 as7726-32x-1 NOTICE swss#orchagent: :- initPort: Initialized port Ethernet8
Apr 29 03:28:18.953485 as7726-32x-1 NOTICE swss#portsyncd: :- main: PortInitDone
Apr 29 03:28:18.957141 as7726-32x-1 NOTICE swss#orchagent: :- doPortTask: Set port Ethernet8 admin status to up

- How I did it
To change error log condition, only in "port initialization procedure is done , but the port entry not found".

- How to verify it
To run test_mgmtvrf.py::TestReboot::test_reboot case, don't see the ERR log after DUT rebooting

Signed-off-by: kelly_chen@edge-core.com

For lldpmgrd, listen for changes to the PORT table in the CONFIG_DB and APP_DB
To handle alias/description config change.
To check if port is up or down by looking into the oper-status for the port in PORT TABLE in the App DB.
Don't find it in the App DB, will log error.
During initializing, it is possiable that port change in CONFIG_DB and not ready in APP_DB.
@chenkelly chenkelly changed the title To change error log condition in is_port_up() [lldpmgrd] To change error log condition in is_port_up() May 15, 2020
@lguohan lguohan merged commit e0f8aa7 into sonic-net:master May 19, 2020
@lguohan lguohan added the LLDP label May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants