Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Adjust log level to avoid too many thermal logs #4631

Merged
merged 4 commits into from
May 26, 2020

Conversation

Junchao-Mellanox
Copy link
Collaborator

- Why I did it

  1. There are logs that will be printed every 1 minutes which is not necessary
  2. When PSU is not present, we should not set its fan speed and trigger error logs

- How I did it

  1. Trigger thermal log if status change
  2. Test sysfs file before reading it

- How to verify it

Manually verify

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@Junchao-Mellanox Junchao-Mellanox marked this pull request as draft May 22, 2020 02:05
@Junchao-Mellanox Junchao-Mellanox marked this pull request as ready for review May 25, 2020 02:28
@Junchao-Mellanox
Copy link
Collaborator Author

Retest vsimage please

@jleveque jleveque merged commit f277d13 into sonic-net:master May 26, 2020
@abdosi
Copy link
Contributor

abdosi commented May 28, 2020

@Junchao-Mellanox Please create PR for 201911. There is merge conflict.
Removing Request for 201911 Label

@rlhui @liat-grozovik

Junchao-Mellanox added a commit to Junchao-Mellanox/sonic-buildimage that referenced this pull request Jun 1, 2020
…#4631)

* Trigger thermal action log only if thermal condition changes
* test file existence before read file content
* fix error for set psu fan speed
* Remove logs because it print too frequently
@Junchao-Mellanox Junchao-Mellanox deleted the thermal-log branch February 4, 2021 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants