Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert radv docker to buster #4727

Merged
merged 2 commits into from
Jun 12, 2020

Conversation

joyas-joseph
Copy link
Contributor

- Why I did it
This is an enhancement.

- How I did it
Code changes

- How to verify it
Build radv docker using BLDENV=buster make -f Makefile.work target/docker-router-advertiser.gz
Check that /etc/apt/sources.list in radv docker references buster.

- Description for the changelog
Changes to convert radv (router-advertiser) docker to buster

Signed-off-by: Joyas Joseph joyas_joseph@dell.com

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Joyas Joseph <joyas_joseph@dell.com>
@joyas-joseph
Copy link
Contributor Author

retest vsimage please

Copy link
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the rules/radvd.mk Makefile, the version is set to 2.17-2~bpo9+1, as we were building the version which was backported to Stretch. Since we are now building on Buster, this version should be changed to the latest version available for Buster, 2.17-2 (i.e., not the Stretch backport version). Can you please change this and ensure it builds properly?

Signed-off-by: Joyas Joseph <joyas_joseph@dell.com>
@joyas-joseph
Copy link
Contributor Author

It builds fine. I see radvd_2.17-2_amd64.deb created.

@lguohan lguohan merged commit 1714e62 into sonic-net:master Jun 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants