Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[201911] DellEMC: Skip thermalctld and thermal platform API changes #4752

Merged
merged 1 commit into from
Jun 11, 2020

Conversation

ArunSaravananBalachandran
Copy link
Contributor

- Why I did it

  • Skip thermalctld in DellEMC S6000, S6100, Z9100 and Z9264 platforms.
  • Change the return type of thermal Platform APIs in DellEMC S6000, S6100 and Z9100 platforms to 'float'.

- How I did it

  • Add 'skip_thermalctld:true' in pmon_daemon_control.json for DellEMC S6000, S6100, Z9100 and Z9264 platforms.
  • Made changes in thermal.py, for 'get_temperature', 'get_high_threshold' and 'get_low_threshold' to return 'float' value.

- How to verify it

  • Check thermalctld is not running in 'pmon'.
  • Wrote a python script to load Chassis class and then call the APIs accordingly and verify the return type.

UT Logs: UT_logs.txt
Test Script : thermal_test_py.txt

- Description for the changelog

[201911] DellEMC: Skip thermalctld and thermal platform API changes

- A picture of a cute animal (not mandatory but encouraged)

@jleveque jleveque merged commit 093d773 into sonic-net:201911 Jun 11, 2020
@ArunSaravananBalachandran ArunSaravananBalachandran deleted the thermal_201911 branch July 17, 2020 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants