Support for connecting to DB in namespace via TCP port in multi-asic platform. #4779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bridge network ) for applications in multi-asic platform.
qiluo-msft
reviewed
Jun 18, 2020
qiluo-msft
reviewed
Jun 18, 2020
qiluo-msft
reviewed
Jun 18, 2020
| @@ -20,7 +20,7 @@ stderr_logfile=syslog | |||
| {% if INSTANCES %} | |||
| {% for redis_inst, redis_items in INSTANCES.iteritems() %} | |||
| [program: {{ redis_inst }}] | |||
| command=/bin/bash -c "{ [[ -s /var/lib/{{ redis_inst }}/dump.rdb ]] || rm -f /var/lib/{{ redis_inst }}/dump.rdb; } && mkdir -p /var/lib/{{ redis_inst }} && exec /usr/bin/redis-server /etc/redis/redis.conf --port {{ redis_items['port'] }} --unixsocket {{ redis_items['unix_socket_path'] }} --pidfile /var/run/redis/{{ redis_inst }}.pid --dir /var/lib/{{ redis_inst }}" | |||
| command=/bin/bash -c "{ [[ -s /var/lib/{{ redis_inst }}/dump.rdb ]] || rm -f /var/lib/{{ redis_inst }}/dump.rdb; } && mkdir -p /var/lib/{{ redis_inst }} && exec /usr/bin/redis-server /etc/redis/redis.conf --bind {{ LOOPBACK_IP }} {{ redis_items['hostname'] }} --port {{ redis_items['port'] }} --unixsocket {{ redis_items['unix_socket_path'] }} --pidfile /var/run/redis/{{ redis_inst }}.pid --dir /var/lib/{{ redis_inst }}" | |||
There was a problem hiding this comment.
just wonder is there any case both LOOPBACK_IP and HOST_IP are empty, if there is a case , the --bind without parameter will work or NOT ?
There was a problem hiding this comment.
This case should not happen as the LOOPBACK_IP is hardcoded to 127.0.0.1 , the HOST_IP is either 127.0.0.1 ( in case of linux host namespace ) or the docker0 IP address in case of namespaces. But I can add the the default fallback IP of 127.0.0.1, if this error scenario arises.
There was a problem hiding this comment.
Updated the code, so that if we are not able to get the ip address correctly from interface, it is set to loopback ip 127.0.0.1 as the default.
There was a problem hiding this comment.
@dzhangalibaba let me know it this was ok ?
qiluo-msft
reviewed
Jun 20, 2020
qiluo-msft
reviewed
Jun 24, 2020
…terface fails. Moved the localhost loopback IP binding logic into the supervisor.j2 file.
qiluo-msft
reviewed
Jun 25, 2020
qiluo-msft
previously approved these changes
Jun 26, 2020
dzhangalibaba
previously approved these changes
Jun 28, 2020
This was causing redis server to not start up as command string was coming in same line as program:
judyjoseph
dismissed stale reviews from dzhangalibaba and qiluo-msft
via
80e77b2
dzhangalibaba
approved these changes
Jun 30, 2020
qiluo-msft
approved these changes
Jun 30, 2020
abdosi
pushed a commit
that referenced
this pull request
Jul 5, 2020
…platform. (#4779) * Support for connecting to DB in namespace via IP:port ( using docker bridge network ) for applications in multi-asic platform. * Added the default IP as 127.0.0.1 if the IPaddress derivation from interface fails. Moved the localhost loopback IP binding logic into the supervisor.j2 file.
qiluo-msft
pushed a commit
to qiluo-msft/sonic-buildimage
that referenced
this pull request
Jul 12, 2020
…platform. (sonic-net#4779) * Support for connecting to DB in namespace via IP:port ( using docker bridge network ) for applications in multi-asic platform. * Added the default IP as 127.0.0.1 if the IPaddress derivation from interface fails. Moved the localhost loopback IP binding logic into the supervisor.j2 file.
qiluo-msft
pushed a commit
to qiluo-msft/sonic-buildimage
that referenced
this pull request
Jul 12, 2020
…platform. (sonic-net#4779) * Support for connecting to DB in namespace via IP:port ( using docker bridge network ) for applications in multi-asic platform. * Added the default IP as 127.0.0.1 if the IPaddress derivation from interface fails. Moved the localhost loopback IP binding logic into the supervisor.j2 file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
Currently in multi-asic platform support exists only for using UNIX socket to connect to DB in different namespaces. There are permission restrictions with the redis unix socket file because of which applications needs to either be running as root user or need to specify sudo to be able to use it.
Certain applications like "show commands" are currently being called without sudo and hence cannot use the redis unix socket to connect to DB in other namespaces. Hence introducing this option to connect using TCP port.
Note - redis unix socket is still the preferred way due to better performance !!
- How I did it
Updated the database_config.json.j2 to use HOST_IP which is derived from either loopback interface in case of linux host, or eth0 interface ( which is connected to docker bridge network ) in the other namespaces.
In the namespaces the redis server is started on multiple IP address (loop back IP and eth0 IP ) with the "bind' option. We have to use the loopback IP as there are multiple applications using host=127.0.0.1 as hardcoding in the connector class object.
- How to verify it
Verified with the show/config commands.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)