-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added files to create SKU Mellanox-SN3800-D24C52 #4808
added files to create SKU Mellanox-SN3800-D24C52 #4808
Conversation
@@ -0,0 +1 @@ | |||
SAI_INIT_CONFIG_FILE=/usr/share/sonic/hwsku/sai_3800.xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly keep the name as sai_3800_24x50g_52x100g as that's a convention followed for other SKU's as well. You can check this . It can be used to identify the file in syncd docker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed in the next commit
@@ -0,0 +1,77 @@ | |||
# name lanes alias index speed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@madhanmellanox please use the same alignment as in this PR: #4085
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@madhanmellanox do we need fec for this SKU?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SKU is generated by sonic_sku_create.py and it is using tabulate method of tabulate module, that is the reason for the alignment.
FEC is not present in the 2700 SKUs. So, FEC is not mandatory.
<device-mac-address>00:02:03:04:05:00</device-mac-address> | ||
|
||
<!-- ISSU enabled --> | ||
<issu-enabled>1</issu-enabled> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@madhanmellanox please fix alignment. Also make sure spaces (not tabs) are used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sai_3800_24x50g_52x100g.xml is a copy of ../ACS-3800/sai_3800.xml
* added files to create SKU Mellanox-SN3800-D24C52 Co-authored-by: Madhan Babu <madhan@arc-build-server.mtr.labs.mlnx>
What I did
Added all the relevant files to create SKU Mellanox-SN3800-D24C52
How I did it
Created all the SKU related files using a XML file provided and a sonic_sku_create.py script to generate the files.
How to verify it
Load the new HWKU related config using follow command and reload the config.
sudo sonic-cfggen --preset l2 -p -H -k Mellanox-SN3800-D24C52 > /tmp/newconfig
sudo cp /tmp/newconfig /etc/sonic/config_db.json
sudo config reload
show interfaces status
Description for the changelog
Added SKU related files buffers_defaults_t0.j2, buffers_defaults_t1.j2, buffers.json.j2, pg_profile_lookup.ini, port_config.ini, qos.json.j2, sai_3800.xml and sai.profile.
- A picture of a cute animal (not mandatory but encouraged)