[sonic-swss] Update submodule #4977
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
changed the title
|
@madhanmellanox: I have updated the PR title to match our naming convention. Also, please do not add |
|
Retest this please |
1 similar comment
|
Retest this please |
|
retest this please |
1 similar comment
|
retest this please |
|
Retest this please |
1 similar comment
|
Retest this please |
|
obsoleted by #5002 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
Updating submodule for sonic-swss to get the changes to Azure master. The following were the commits that were part of this submodule.
changed method AclRuleL3::validateAddAction() and AclRuleL3::getRedirectObjectId() to handle all ACL redirect cases 1b4f5866914b6509daa9898eb0b37e2ab50baa6d
Handled string handling of attr_value in AclRuleL3::validateAddAction() method 9471eb33ccb1e0f5be728c8bac220f2d340c9662
added VS testcases for ACL redirect and priority ACL tests 206bacd4b36af369effa9bbafba3d96de46cbe7f
removed test_AclpriorityRule() test case, as it does not belong here 9bcc906de9eea9ec8411c3b17c4a7b162508e831
removed test_AclprioriyRule() test case as it does not belong here f886b324deb31d56887ea56664adbd535325a523
redone the wrongly done resolved conflict of test_acl.py file c370577e19d26e696fb84a45268fc2fb0c11c68b
address vs test failure cc468b8e58e974ccfa35601baabfff104b9b305e
addressed vs test failure 2f8da3e5de6886f9242f8c00735307fd4377c978
fixed self.asic_db.wait_for_n_keys to self.dvs_acl.asic_db.wait_for_n_keys in the relevant test case 17b786d9c44b1227b5389cefa015f9cbd55a07e5
fixed all the required function calls relevant to dvs_acl in my testcase 63e5b7935a0b10bbb3281b484119dce8053f18b0
- How I did it
Merged sonic-swss changes for ACL redirect defect to Azure master. Now, updating the submodule changes.
- How to verify it
Verify both the type of ACL redirect rule works.
- Description for the changelog
Changes are in aclorchagent.cpp file to handle both kinds of ACL redirect rules.
- A picture of a cute animal (not mandatory but encouraged)