-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sonic-telemetry][sonic-mgmt-common] Update submodules #4986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
changed the title
[sonic-telemetry] Update submodule
[sonic-telemetry][sonic-mgmt-common] Update submodules
Jul 17, 2020
Retest broadcom please |
jleveque
pushed a commit
to sonic-net/sonic-telemetry
that referenced
this pull request
Jul 21, 2020
This was the result of running go get github.com/openconfig/gnmi This was required to fix build issue seen in sonic-net/sonic-buildimage#4986 After adding these changes I did a make clean && rm -rf vendor in both sonic-telemetry and sonic-mgmt-common repo and was able to build.
Retest broadcom please |
hui-ma
approved these changes
Jul 22, 2020
hui-ma
approved these changes
Jul 22, 2020
TildenWinston
pushed a commit
to TildenWinston/sonic-telemetry
that referenced
this pull request
Aug 7, 2020
This was the result of running go get github.com/openconfig/gnmi This was required to fix build issue seen in sonic-net/sonic-buildimage#4986 After adding these changes I did a make clean && rm -rf vendor in both sonic-telemetry and sonic-mgmt-common repo and was able to build.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
src/sonic-telemetry fa8d498...3bd7ca3 (4):
src/sonic-mgmt-common 444aa9a...cc01ce4 (4):
Note: sonic-telemetry submodule update is dependent upon sonic-mgmt-common submodule update, thus updating both in this patch