[build]: wait for conflicts package to be uninstalled #5039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
previously approved these changes
Jul 25, 2020
jleveque
previously approved these changes
Jul 25, 2020
when parallel build is enabled, both docker-fpm-frr and docker-syncd-brcm is built at the same time, docker-fpm-frr requires swss which requires to install libsaivs-dev. docker-syncd-brcm requires syncd package which requires to install libsaibcm-dev. since libsaivs-dev and libsaibcm-dev install the sai header in the same location, these two packages cannot be installed at the same time. Therefore, we need to serialize the build between these two packages. Simply uninstall the conflict package is not enough to solve this issue. The correct solution is to have one package wait for another package to be uninstalled. For example, if syncd is built first, then it will install libsaibcm-dev. Meanwhile, if the swss build job starts and tries to install libsaivs-dev, it will first try to query if libsaibcm-dev is installed or not. if it is installed, then it will wait until libsaibcm-dev is uninstalled. After syncd job is finished, it will uninstall libsaibcm-dev and swss build job will be unblocked. To solve this issue, _UNINSTALLS is introduced to uninstall a package that is no longer needed and to allow blocked job to continue. Signed-off-by: Guohan Lu <lguohan@gmail.com>
lguohan
changed the title
qiluo-msft
approved these changes
Jul 27, 2020
3 tasks
guxianghong
added a commit
to guxianghong/sonic-buildimage
that referenced
this pull request
Nov 9, 2020
…Merge these optimization to Centec ARM64 platform.
lguohan
added a commit
to lguohan/sonic-buildimage
that referenced
this pull request
Jan 20, 2021
when parallel build is enabled, both docker-fpm-frr and docker-syncd-brcm is built at the same time, docker-fpm-frr requires swss which requires to install libsaivs-dev. docker-syncd-brcm requires syncd package which requires to install libsaibcm-dev. since libsaivs-dev and libsaibcm-dev install the sai header in the same location, these two packages cannot be installed at the same time. Therefore, we need to serialize the build between these two packages. Simply uninstall the conflict package is not enough to solve this issue. The correct solution is to have one package wait for another package to be uninstalled. For example, if syncd is built first, then it will install libsaibcm-dev. Meanwhile, if the swss build job starts and tries to install libsaivs-dev, it will first try to query if libsaibcm-dev is installed or not. if it is installed, then it will wait until libsaibcm-dev is uninstalled. After syncd job is finished, it will uninstall libsaibcm-dev and swss build job will be unblocked. To solve this issue, _UNINSTALLS is introduced to uninstall a package that is no longer needed and to allow blocked job to continue. Signed-off-by: Guohan Lu <lguohan@gmail.com>
4 tasks
lguohan
added a commit
that referenced
this pull request
Jan 21, 2021
when parallel build is enabled, both docker-fpm-frr and docker-syncd-brcm is built at the same time, docker-fpm-frr requires swss which requires to install libsaivs-dev. docker-syncd-brcm requires syncd package which requires to install libsaibcm-dev. since libsaivs-dev and libsaibcm-dev install the sai header in the same location, these two packages cannot be installed at the same time. Therefore, we need to serialize the build between these two packages. Simply uninstall the conflict package is not enough to solve this issue. The correct solution is to have one package wait for another package to be uninstalled. For example, if syncd is built first, then it will install libsaibcm-dev. Meanwhile, if the swss build job starts and tries to install libsaivs-dev, it will first try to query if libsaibcm-dev is installed or not. if it is installed, then it will wait until libsaibcm-dev is uninstalled. After syncd job is finished, it will uninstall libsaibcm-dev and swss build job will be unblocked. To solve this issue, _UNINSTALLS is introduced to uninstall a package that is no longer needed and to allow blocked job to continue. Signed-off-by: Guohan Lu <lguohan@gmail.com>
abdosi
pushed a commit
that referenced
this pull request
Jan 27, 2021
when parallel build is enabled, both docker-fpm-frr and docker-syncd-brcm is built at the same time, docker-fpm-frr requires swss which requires to install libsaivs-dev. docker-syncd-brcm requires syncd package which requires to install libsaibcm-dev. since libsaivs-dev and libsaibcm-dev install the sai header in the same location, these two packages cannot be installed at the same time. Therefore, we need to serialize the build between these two packages. Simply uninstall the conflict package is not enough to solve this issue. The correct solution is to have one package wait for another package to be uninstalled. For example, if syncd is built first, then it will install libsaibcm-dev. Meanwhile, if the swss build job starts and tries to install libsaivs-dev, it will first try to query if libsaibcm-dev is installed or not. if it is installed, then it will wait until libsaibcm-dev is uninstalled. After syncd job is finished, it will uninstall libsaibcm-dev and swss build job will be unblocked. To solve this issue, _UNINSTALLS is introduced to uninstall a package that is no longer needed and to allow blocked job to continue. Signed-off-by: Guohan Lu <lguohan@gmail.com>
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…endency (sonic-net#5834) * LIBSAIREDIS isn't depend on CENTEC_SAI remove this dependence * Build depends are optimized in PR sonic-net#4880 and sonic-net#5039. Merge these optimization to Centec ARM64 platform.
guxianghong
pushed a commit
to CentecNetworks/sonic-buildimage
that referenced
this pull request
Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
Fix #4912
Signed-off-by: Guohan Lu lguohan@gmail.com
- How I did it
To solve this issue, _UNINSTALLS is introduced to uninstall a package that
is no longer needed and to allow blocked job to continue.
- How to verify it
make SONIC_BUILD_JOBS=8 target/sonic-broadcom.bin
- Which release branch to backport (provide reason below if seleted)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)