[System logs]: Eliminate duplicate log messages and attempt rotation more frequently #520
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # Edit this file to introduce tasks to be run by cron. | ||
| # | ||
| # Each task to run has to be defined through a single line | ||
| # indicating with different fields when the task will be run | ||
| # and what command to run for the task | ||
| # | ||
| # To define the time you can provide concrete values for | ||
| # minute (m), hour (h), day of month (dom), month (mon), | ||
| # and day of week (dow) or use '*' in these fields (for 'any').# | ||
| # Notice that tasks will be started based on the cron's system | ||
| # daemon's notion of time and timezones. | ||
| # | ||
| # Output of the crontab jobs (including errors) is sent through | ||
| # email to the user the crontab file belongs to (unless redirected). | ||
| # | ||
| # For example, you can run a backup of all your user accounts | ||
| # at 5 a.m every week with: | ||
| # 0 5 * * 1 tar -zcf /var/backups/home.tgz /home/ | ||
| # | ||
| # For more information see the manual pages of crontab(5) and cron(8) | ||
| # | ||
| # m h dom mon dow command | ||
|
|
||
| * * * * * /usr/sbin/logrotate -f /etc/logrotate.d/rsyslog | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| /var/log/syslog | ||
| /var/log/quagga/*.log | ||
| /var/log/sonic/*.log | ||
|
There was a problem hiding this comment. /var/log/sonic? Are we using this? There was a problem hiding this comment. Not currently. Please see my first comment on 00-sonic.conf up above. |
||
| /var/log/teamd.log | ||
| { | ||
| rotate 7 | ||
| # Removed 'daily' interval, as we now call logrotate more frequently via cron | ||
| # and we want to check these logs every time | ||
| # daily | ||
| size 100M | ||
| missingok | ||
| notifempty | ||
| compress | ||
| delaycompress | ||
| postrotate | ||
| invoke-rc.d rsyslog rotate > /dev/null | ||
| endscript | ||
| } | ||
| /var/log/mail.info | ||
| /var/log/mail.warn | ||
| /var/log/mail.err | ||
| /var/log/mail.log | ||
| /var/log/daemon.log | ||
| /var/log/kern.log | ||
| /var/log/auth.log | ||
| /var/log/user.log | ||
| /var/log/lpr.log | ||
| /var/log/cron.log | ||
| /var/log/debug | ||
| /var/log/messages | ||
| { | ||
| rotate 4 | ||
| weekly | ||
| size 100M | ||
| missingok | ||
| notifempty | ||
| compress | ||
| delaycompress | ||
| sharedscripts | ||
| postrotate | ||
| invoke-rc.d rsyslog rotate > /dev/null | ||
| endscript | ||
| } | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| ## Quagga rules | ||
|
|
||
| if $programname == ["quagga", | ||
| "watchquagga", | ||
| "zebra"] | ||
| then { | ||
| /var/log/quagga/zebra.log | ||
| stop | ||
| } | ||
|
|
||
| if $programname == "bgpd" then { | ||
| /var/log/quagga/bgpd.log | ||
| stop | ||
| } | ||
|
|
||
| ## Teamd rules | ||
|
|
||
| if $programname contains "teamd_" then { | ||
| /var/log/teamd.log | ||
| stop | ||
| } | ||
|
|
||
| ## SONiC rules | ||
|
|
||
| if $programname == ["fpmsyncd", | ||
| "intfsyncd", | ||
| "neighsyncd", | ||
| "orchagent", | ||
| "portsyncd", | ||
| "saidump", | ||
| "saiplayer", | ||
| "syncd", | ||
| "swssconfig", | ||
| "swssloglevel", | ||
| "teamsyncd", | ||
| "updategraph"] | ||
| then { | ||
| ?SONiCPerProcessLogfile,SONiCFileFormat | ||
|
There was a problem hiding this comment. Per-process SONiC logging is not currently working. I don't think John finished this. I updated the list of programs, just in case we want it working, but I believe we'd just like everything to log to /var/log/syslog. If so, I will remove this. Please share your thoughts. There was a problem hiding this comment. I decided to pull this for now, as it was incomplete. We can revisit it again in the future. |
||
| stop | ||
| } | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # This file is part of systemd. | ||
| # | ||
| # systemd is free software; you can redistribute it and/or modify it | ||
| # under the terms of the GNU Lesser General Public License as published by | ||
| # the Free Software Foundation; either version 2.1 of the License, or | ||
| # (at your option) any later version. | ||
| # | ||
| # See journald.conf(5) for details | ||
|
|
||
| [Journal] | ||
| #Storage=auto | ||
| #Compress=yes | ||
| #Seal=yes | ||
| #SplitMode=uid | ||
| #SyncIntervalSec=5m | ||
| #RateLimitInterval=30s | ||
| #RateLimitBurst=1000 | ||
| SystemMaxUse=50MB | ||
| #SystemKeepFree= | ||
| #SystemMaxFileSize= | ||
| RuntimeMaxUse=50MB | ||
| #RuntimeKeepFree= | ||
| #RuntimeMaxFileSize= | ||
| #MaxRetentionSec= | ||
| #MaxFileSec=1month | ||
| #ForwardToSyslog=yes | ||
| #ForwardToKMsg=no | ||
| #ForwardToConsole=no | ||
| #ForwardToWall=yes | ||
| #TTYPath=/dev/console | ||
| #MaxLevelStore=debug | ||
| #MaxLevelSyslog=debug | ||
| #MaxLevelKMsg=notice | ||
| #MaxLevelConsole=info | ||
| #MaxLevelWall=emerg | ||
|
There was a problem hiding this comment. Why do we need to comment all entries out of this file? There was a problem hiding this comment. This is how John originally added the file. He only intended to take advantage of There was a problem hiding this comment. I'm good with this. Thanks |
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better put this as a file into /etc/cron.d/ ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current directory structure of files/image_config is not set to mirror the structure of /etc on the SONiC image. If we want to do this for crontab, we should rearrange everything into the /etc/... hierarchy to make things clear across the board.
Also, with our Debian distribution, crontab lives directly in /etc, not in /etc/cron.d.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I see in SONiC
$ ls /etc/cron*
/etc/crontab
/etc/cron.d:
/etc/cron.daily:
apt bsdmainutils dpkg logrotate ntp passwd
/etc/cron.hourly:
/etc/cron.monthly:
/etc/cron.weekly:
Can we put a file to /etc/cron.d/ directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha. Done.