[database]: Remove hard/soft limits for client-output-buffer in redis #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is to solve sonic-net/sonic-sairedis#176. |
|
Please don't merge it until it's done testing |
|
It's ready to be merged |
lguohan
reviewed
Apr 26, 2017
| @@ -28,7 +28,8 @@ RUN sed -ri 's/^(save .*$)/# \1/g; | |||
| s/^daemonize yes$/daemonize no/; \ | |||
| s/^logfile .*$/logfile ""/; \ | |||
| s/^# syslog-enabled no$/syslog-enabled no/; \ | |||
| s/^# unixsocket/unixsocket/ \ | |||
| s/^# unixsocket/unixsocket/; \ | |||
| s/^client-output-buffer-limit pubsub 32mb 8mb 60/client-output-buffer-limit pubsub 0 0 0/ \ | |||
There was a problem hiding this comment.
use regex \d+mb \d+mb \d+?
There was a problem hiding this comment.
Done. \d didn't work for sed -ir
lguohan
approved these changes
Apr 26, 2017
stcheng
pushed a commit
that referenced
this pull request
Apr 26, 2017
…#539) * Remove hard/soft limits for client-output-buffer in redis Otherwise when we have a lot of updates from orchagent to syncd latter one can't process queues fast enough and redic-database disconnect both orchagent and syncd. orchagent and syncd doesn't have logic to deal with it and just crash
lguohan
added a commit
that referenced
this pull request
Jul 28, 2018
* 8f52e29 2018-07-25 | Postpone intf task after buffer configuration applied on the port. (#539) (HEAD, origin/201803) [Jipan Yang] * 2d2fdaa 2018-07-26 | [portsorch]: Refix: Don't print error when alias equal to PortConfigDone (#548) [Qi Luo] * 87d34db 2018-07-12 | [MirrorOrch]: Fix bug when NULL is returned from the getenv function (#537) [Shuotian Cheng]
lguohan
pushed a commit
that referenced
this pull request
Jan 22, 2020
update multiDB changes in sairedis, including: [MultiDB]: repalce old APIs with New APIs incuding testing (#537) [syncd] Move port map and port map parser to proper class (#542) [syncd] Update syncd to expect correct object query message (#548) Support for snat available entry switch attribute in vslib (needed to run vs pytests) (#546) Move apiInitialized flag to Globals namespace (#545) Move command line options and parser to separate classes (#541) Move ntf_queue to proper NotificationQueue class (#539) Move api mutex to global class and add sairedis namespace (#544) Clean sairedis.h header (#543) Fix mlnx.pl script for perl include local directory (#540) Layer 2 Forwarding Enhancements (#510) Signed-off-by: Dong Zhang d.zhang@alibaba-inc.com
madhanmellanox
pushed a commit
to madhanmellanox/sonic-buildimage
that referenced
this pull request
Mar 23, 2020
…onic-net#539) This also ensures all port setting applied before intf setting. Signed-off-by: Jipan Yang <jipan.yang@alibaba-inc.com>
dmytroxshevchuk
pushed a commit
to dmytroxshevchuk/sonic-buildimage
that referenced
this pull request
Aug 31, 2020
* Move ntf_queue to proper NotificationQueue class * add extra aspell exception * Address comments
TACappleman
added a commit
to Metaswitch/sonic-buildimage
that referenced
this pull request
Oct 27, 2021
[schema] Add EXP to TC map config table (sonic-net#537) [CI]: Swap the python code coverage report with the cpp report (sonic-net#544) Remove SWIG generated files from coverage report (sonic-net#542) Update database defintions for PINs / P4Runtime (sonic-net#536) [ci]: Support code coverage (sonic-net#539) Fix the option missing in kernel config issue (sonic-net#541) Add SRV6 APP tables (sonic-net#538) [schema] Rename CBF config tables (sonic-net#535)
lguohan
pushed a commit
that referenced
this pull request
Oct 28, 2021
[schema] Add EXP to TC map config table (#537) [CI]: Swap the python code coverage report with the cpp report (#544) Remove SWIG generated files from coverage report (#542) Update database defintions for PINs / P4Runtime (#536) [ci]: Support code coverage (#539) Fix the option missing in kernel config issue (#541) Add SRV6 APP tables (#538) [schema] Rename CBF config tables (#535)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary/fast fix for sonic-net/sonic-sairedis#176