Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[swss] Start Restore Neighbor After SWSS Config #5451

Conversation

tahmed-dev
Copy link
Contributor

@tahmed-dev tahmed-dev commented Sep 24, 2020

SWSS config script restore ARP/FDB/Routes. Restore neighbor script
uses config DB ARP information to restore ARP entries and so needs
to be started after swssconfig exits.

Fixes: #5217
Closes: #5217

signed-off-by: Tamer Ahmed tamer.ahmed@microsoft.com

- Why I did it
Fixes start dependencies that causes ARP entries to not be restored during fast-reboot

- How I did it
Change supervisord config on order to ensure restore_neigh runs after swssconfig.sh

- How to verify it
fast-reboot succeeds

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

SWSS config script restore ARP/FDB/Routes. Restore neighbor script
uses config DB ARP information to restore ARP entries and so needs
to be started after swssconfig exits.

signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
@yxieca
Copy link
Contributor

yxieca commented Sep 24, 2020

@tahmed-dev Do we need this change in 201811 as well?

@tahmed-dev
Copy link
Contributor Author

@tahmed-dev Do we need this change in 201811 as well?

@yxieca No we don't. PR:4599 is only in 201911 and 202006

@tahmed-dev tahmed-dev merged commit b43f112 into sonic-net:master Sep 24, 2020
abdosi pushed a commit that referenced this pull request Sep 28, 2020
SWSS config script restore ARP/FDB/Routes. Restore neighbor script
uses config DB ARP information to restore ARP entries and so needs
to be started after swssconfig exits.

signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
SWSS config script restore ARP/FDB/Routes. Restore neighbor script
uses config DB ARP information to restore ARP entries and so needs
to be started after swssconfig exits.

signed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[fast-reboot] ARP entries are not restored after fast-reboot
5 participants