Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MACsec container and wpa_supplicant component #5700

Merged
merged 30 commits into from
Jan 10, 2021

Conversation

Pterosaur
Copy link
Contributor

@Pterosaur Pterosaur commented Oct 22, 2020

- Why I did it
Make SONiC support MACsec feature
The HLD about MACsec feature is at : MACsec HLD

- How I did it
Add MACsec container and sonic-wpa-supplicant

- How to verify it
This PR doesn't set MACsec container automatically start, You should manually start the container by docker run docker-macsec
wpa_supplicant binary can be found at MACsec container.
This PR depends on the PR, WPA_SUPPLICANT, and The MACsec container will be set as automatically start by later PR.

- A picture of a cute animal (not mandatory but encouraged)
🐉

Pterosaur and others added 20 commits April 23, 2020 18:56
Signed-off-by: zegan <zegan@microsoft.com>
Signed-off-by: zegan <zegan@microsoft.com>
Signed-off-by: zegan <zegan@microsoft.com>
Signed-off-by: zegan <zegan@microsoft.com>
Signed-off-by: zegan <zegan@microsoft.com>
Signed-off-by: zegan <zegan@microsoft.com>
Signed-off-by: zegan <zegan@microsoft.com>
Signed-off-by: zegan <zegan@microsoft.com>
Signed-off-by: zegan <zegan@microsoft.com>
Signed-off-by: zegan <zegan@microsoft.com>
Signed-off-by: Ze Gan <ganze718@gmail.com>
Signed-off-by: Ze Gan <ganze718@gmail.com>
Signed-off-by: Ze Gan <ganze718@gmail.com>
Signed-off-by: Ze Gan <ganze718@gmail.com>
Signed-off-by: Ze Gan <ganze718@gmail.com>
@Pterosaur
Copy link
Contributor Author

retest vsimage please

@Pterosaur
Copy link
Contributor Author

retest vs please

@Pterosaur
Copy link
Contributor Author

retest mellanox please

@Pterosaur
Copy link
Contributor Author

retest baseimage please

Signed-off-by: Ze Gan <ganze718@gmail.com>
Signed-off-by: Ze Gan <ganze718@gmail.com>
Signed-off-by: Ze Gan <ganze718@gmail.com>
Signed-off-by: Ze Gan <ganze718@gmail.com>
rm -rf ./wpa

# Clone wpa repo
# git clone https://github.com/Azure/sonic-wpa-supplicant.git

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the issue regarding the repo in Azure? Why are we still using debian repo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the repo in Azure doesn't include debian rule to build the debian package.
This PR need wait another PR(haven't been created) to add debian build rule for sonic-wpa-supplicant. So this PR is draft status right now.

@caizhenghui-juniper
Copy link

In critical process file, do we not want to watch any processes? e.g. macsecmgr?

@Pterosaur
Copy link
Contributor Author

Pterosaur commented Nov 18, 2020

In critical process file, do we not want to watch any processes? e.g. macsecmgr?

Yes, you are right. But I believe we will have another PR to set up all runtime environment or requirement. This PR is just for creating all components for integration and others need to start each components manually.

Signed-off-by: Ze Gan <ganze718@gmail.com>
@Pterosaur Pterosaur marked this pull request as ready for review December 7, 2020 16:41
Signed-off-by: Ze Gan <ganze718@gmail.com>
@Pterosaur
Copy link
Contributor Author

retest this please

@Pterosaur Pterosaur marked this pull request as draft January 1, 2021 02:07
@Pterosaur
Copy link
Contributor Author

retest vsimage please

Signed-off-by: Ze Gan <ganze718@gmail.com>
Signed-off-by: Ze Gan <ganze718@gmail.com>
@Pterosaur
Copy link
Contributor Author

retest vsimage please

@Pterosaur Pterosaur marked this pull request as ready for review January 9, 2021 12:48
@Pterosaur
Copy link
Contributor Author

@lguohan Please review this PR.

@lguohan
Copy link
Collaborator

lguohan commented Jan 10, 2021

we need to add critical process in macsec container.

@lguohan
Copy link
Collaborator

lguohan commented Jan 10, 2021

why is that supervisord.conf is empty? are we not starting any process right now?

@lguohan lguohan merged commit c225752 into sonic-net:master Jan 10, 2021
@Pterosaur
Copy link
Contributor Author

why is that supervisord.conf is empty? are we not starting any process right now?

Yes, I will submit another PR for starting MACsec Manager in MACsec container.

qtbase5-dev \
aspell-en \
libhiredis-dev \
libnl-3-dev \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We build our own libnl3 and libhiredis. Please depend on them instead of pre-install the vanilla ones in sonic-slave.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants