Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[synchronous-mode] Enable synchronous mode by default #5735

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

shi-su
Copy link
Contributor

@shi-su shi-su commented Oct 28, 2020

- Why I did it
To enable synchronous mode by default.

- How I did it
Modify swss_vars.j2 template file and add enabling synchronous mode in minigraph parser.

- How to verify it

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@shi-su shi-su requested a review from qiluo-msft October 28, 2020 18:43
@qiluo-msft qiluo-msft requested review from lguohan and kcudnik October 29, 2020 01:00
Copy link
Collaborator

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shi-su
Copy link
Contributor Author

shi-su commented Oct 29, 2020

retest vsimage please

1 similar comment
@lguohan
Copy link
Collaborator

lguohan commented Oct 29, 2020

retest vsimage please

@shi-su shi-su merged commit 5ee5c13 into sonic-net:master Oct 29, 2020
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants