[core_uploader.py] Convert to Python 3; Use logger from sonic-py-common for uniform logging #5790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
This pull request fixes 6 alerts when merging 418f6e9 into 9d73552 - view on LGTM.com fixed alerts:
|
|
This pull request fixes 6 alerts when merging 62b0522 into 215ce13 - view on LGTM.com fixed alerts:
|
renukamanavalan
previously approved these changes
Nov 4, 2020
…7.0, the package has been split up
renukamanavalan
approved these changes
Nov 4, 2020
|
This pull request fixes 6 alerts when merging 3825a63 into ba7fda7 - view on LGTM.com fixed alerts:
|
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…on for uniform logging (sonic-net#5790) - Convert core_uploader.py script to Python 3 - Use logger from sonic-py-common for uniform logging - Reorganize imports alphabetically per PEP8 standard - Two blank lines precede functions per PEP8 standard - Remove unnecessary global variable declarations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
As part of moving all SONiC code from Python 2 (no longer supported) to Python 3
- How I did it
- How to verify it
Ensure core_uploader.py still functions correctly
- Which release branch to backport (provide reason below if selected)