Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonic-device-data] Convert Python files to Python 3 #5816

Merged
merged 1 commit into from
Nov 5, 2020
Merged

[sonic-device-data] Convert Python files to Python 3 #5816

merged 1 commit into from
Nov 5, 2020

Conversation

jleveque
Copy link
Contributor

@jleveque jleveque commented Nov 4, 2020

- Why I did it

As part of moving all SONiC code from Python 2 (no longer supported) to Python 3

- How I did it

  • Convert config_checker, media_checker and platform_json_checker scripts to Python 3
  • Reorganize imports per PEP8 standard
  • Two blank lines precede functions per PEP8 standard

- How to verify it

Ensure scripts still function correctly

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

@jleveque jleveque marked this pull request as ready for review November 5, 2020 19:16
@jleveque jleveque merged commit 2c9454e into sonic-net:master Nov 5, 2020
@jleveque jleveque deleted the sonic-device-data_py3 branch November 5, 2020 19:17
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
- Convert config_checker, media_checker and platform_json_checker scripts to Python 3
- Reorganize imports per PEP8 standard
- Two blank lines precede functions per PEP8 standard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants