Platform: Add support for the Nokia-7215 platform #5827
Conversation
|
|
|
This pull request introduces 37 alerts when merging 842a094 into 13f8e9c - view on LGTM.com new alerts:
|
|
This pull request introduces 15 alerts when merging b16feec into 13ff7b3 - view on LGTM.com new alerts:
|
|
retest vsimage please |
|
This pull request introduces 11 alerts when merging 22c5f8a into 23b0e07 - view on LGTM.com new alerts:
|
|
The switch MAC address comes from the syseeprom on the ixs7215 just like most other boxes with syseeproms. The previous et6448m marvell/delta product did not have a syseeprom so on that box the mac was placed into profile.ini early in boot up from uboot/ONIE env via a “virtual” syseeprom. The mac address “00:50:43:ee:ee:ee “ is a “dummy” and is replaced with the boxes actual mac address at boot up. I plan to push a change to sonic-py-common/sonic_py_common/device_info.py early this week modifying the “get_system_mac” routine for ['asic_type'] == 'marvell' to clean up the method there. For marvell sai consistency the ixs7215 replaces the dummy mac with the actual syseeprom mac into profile.ini at boot via the nokia-7215init.service calling marvell-armhf/sonic-platform-nokia/7215/scripts/nokia-7215init.sh The marvell sai uses the mac in that file.
Thanks, carl
From: lguohan <notifications@github.com>
Sent: Saturday, November 7, 2020 7:32 PM
To: Azure/sonic-buildimage <sonic-buildimage@noreply.github.com>
Cc: Keene, Carl (Nokia - US/Westford) <carl.keene@nokia.com>; Author <author@noreply.github.com>
Subject: Re: [Azure/sonic-buildimage] Platform: Add support for the Nokia-7215 platform (#5827)
@lguohan commented on this pull request.
________________________________
In device/nokia/armhf-nokia_ixs7215_52x-r0/Nokia-7215/profile.ini<#5827 (comment)>:
@@ -0,0 +1,2 @@
+switchMacAddress=00:50:43:ee:ee:ee
are we hard coding the switch mac address here? and why?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#5827 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/APFZCPMP7ZPXRAWMU5SI6ITSOXRJLANCNFSM4TLYH7YA>.
|
|
This pull request introduces 11 alerts when merging 0e2ba12 into 84aa99d - view on LGTM.com new alerts:
|
|
retest vsimage please |
|
retest broadcom image please |
|
please retest baseimage |
|
retest baseimage please |
|
retest baseimage image please |
| @@ -0,0 +1,379 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
nokia team, is the script python3 compatible?
@jleveque , i think all platform modules should be python3 compatible now since we are switching to python3 now.
There was a problem hiding this comment.
We are currently migrating the platform daemons to Python 3. In the interim, the sonic_platform package should be built as both a Python 2 and Python 3 package, that way the Python 2 package will be used unit the daemons are migrated, then the Python 3 package will be used and we can then eliminate the Python 2 package.
|
what is this vme binary? need to be in source code format. |
| @@ -0,0 +1,17 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
File is not executable; remove shebang.
| @@ -0,0 +1,136 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
File is not executable; remove shebang.
| @@ -0,0 +1,36 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
File is not executable; remove shebang.
|
|
||
|
|
There was a problem hiding this comment.
Remove trailing blank lines
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Remove trailing blank lines
| @@ -0,0 +1,24 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
File is not executable; remove shebang.
| @@ -0,0 +1,227 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
File is not executable; remove shebang.
| @@ -0,0 +1,118 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
File is not executable; remove shebang.
| @@ -0,0 +1,228 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
File is not executable; remove shebang.
| @@ -0,0 +1,137 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
File is not executable; remove shebang.
|
This pull request introduces 11 alerts when merging f40e4bb into 48822be - view on LGTM.com new alerts:
|
|
The VME binary is removed. We will address support for cpld update program "install firmware" in a subsequent PR right away. The shebang is removed and white space cleaned up. We will address adding the python3 wheel per the updated porting guide in additional PR ASAP if thats o.k? |
|
This pull request introduces 11 alerts when merging e97135f into 7c17c58 - view on LGTM.com new alerts:
|
|
This pull request introduces 11 alerts when merging fbbf6aa into b595a6e - view on LGTM.com new alerts:
|
|
@jleveque We have added logic to generate the python3 wheel. |
Platform: armhf-nokia_ixs7215_52x-r0 HwSKU: Nokia-7215 ASIC: marvell Port Config: 48x1G + 4x10G Co-authored-by: dflynn <dennis.flynn@nokia.com> Co-authored-by: Carl Keene <keene@nokia.com>
- Why I did it
Add new Nokia platform
Platform: armhf-nokia_ixs7215_52x-r0
HwSKU: Nokia-7215
ASIC: marvell
Port Config: 48x1G + 4x10G
- How I did it
Provide device and platform related files.
- How to verify it
show platform summary
show platform syseeprom
show platform fan
show platform psustatus
show platform temperature
show platform firmware status
show platform ssdhealth
show interface status
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
Platform: Add support for the Nokia-7215 platform
- A picture of a cute animal (not mandatory but encouraged)