[Mellanox] [201911] Fix issue: set fan led in certain order causes incorrect physical fan led color #6019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: platform/mellanox/mlnx-platform-api/sonic_platform/fan.py
3 tasks
This comment has been minimized.
This comment has been minimized.
liat-grozovik
approved these changes
Nov 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
Fix issue: set fan led in certain order causes incorrect physical fan led color. Say fan1 and fan2 in the same fan drawer and share the same LED. In current implementation, set fan1 to red and set fan2 to green, the final physical LED color is green which is incorrect.
Similar fix is already in master.
- How I did it
Save the led color and determine the final led color by all fans that share the led.
- How to verify it
Run all test cases in test_platform_info.py.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)