Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DPB] [Mellanox] added capability files for SN3420 platform #6020

Merged

Conversation

vadymhlushko-mlnx
Copy link
Contributor

@vadymhlushko-mlnx vadymhlushko-mlnx commented Nov 24, 2020

- Why I did it

platform.json and hwsku.json files are required for a feature called Dynamic Port Breakout

- How I did it

Created capability files according to platform specification SN3420

- How to verify it

Full qualification requires bugs fixes reported under sonic-buildimage

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
Copy link
Collaborator

@liat-grozovik liat-grozovik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4x25 means split, right? but for the first ports we have 1 lane so how can it be 4x25g?
also ports which has 1 lane should not have split capabilities in platform file

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx vadymhlushko-mlnx marked this pull request as draft December 18, 2020 15:53
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Copy link
Contributor Author

retest vs please

@vadymhlushko-mlnx
Copy link
Contributor Author

Please don't merge this PR until [DPB][MLNX][YANG-models] extended regex pattern according to MLNX systems speeds requirements PR will be merged

@vadymhlushko-mlnx vadymhlushko-mlnx marked this pull request as ready for review December 23, 2020 12:58
@liat-grozovik
Copy link
Collaborator

retest vsimage please

@lguohan lguohan merged commit 4e1c102 into sonic-net:master Jan 19, 2021
@vadymhlushko-mlnx vadymhlushko-mlnx deleted the sn3420_dpb_capability_files branch January 20, 2021 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants