[multi-asic] Enhancing monit process checker for multi-asic. #6100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
|
This pull request introduces 1 alert when merging 872cd9f into 6846438 - view on LGTM.com new alerts:
|
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
jleveque
reviewed
Dec 2, 2020
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
|
@jleveque and @yozhao101 can you please review/approve it. |
Will leave a comment later. |
jleveque
reviewed
Dec 3, 2020
yozhao101
reviewed
Dec 3, 2020
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
yozhao101
reviewed
Dec 4, 2020
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
|
The changes look good to me. @jleveque Can you review it again please? |
jleveque
approved these changes
Dec 4, 2020
yozhao101
approved these changes
Dec 4, 2020
abdosi
added a commit
that referenced
this pull request
Dec 4, 2020
Added Support of process checker for work on multi-asic platforms.
abdosi
pushed a commit
to abdosi/sonic-mgmt
that referenced
this pull request
Dec 5, 2020
Signed-off-by: Abhishek Dosi <abdosi@micrsoft.com>
abdosi
added a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
Dec 5, 2020
After the merge of PR#sonic-net/sonic-buildimage#6100 the monit error syslog message will be changed with suffix having more information. Updating the testcases monit syslog matching regex to match the new change
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…et#6100) Added Support of process checker for work on multi-asic platforms.
Merged
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did:
Enhanced the monit process checked to support multi-asic .
How I did:
For given feature we get the host and network namespace instances it's processes should be running
based on it's scope (global/asic) and add it to expected set.
From psutil we get number of running instances of the processes and add where it is running (host/network namespace) using "ip netns identify" to the the actual set
Difference between expected and actual set provides instances where the processes are not running
and will be logged as syslog message by monit
How I verify: