Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] Add python3 support for Mellanox platform API #6175

Merged
merged 5 commits into from
Dec 11, 2020

Conversation

Junchao-Mellanox
Copy link
Collaborator

- Why I did it

python2 is end of life and SONiC is going to support python3. This PR is going to support:

  1. Mellanox SONiC platform API python3 support
  2. Install both python2 and python3 verson of Mellanox SONiC platform API or pmon and host side

- How I did it

  1. Change docker-platform-monitor make files to install both python2 and python3 whl
  2. Change Mellanox SONiC platform API code to support both python2 and python3

- How to verify it

Run platform regressions on a few platforms

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

files/build_templates/sonic_debian_extension.j2 Outdated Show resolved Hide resolved
rules/docker-platform-monitor.mk Outdated Show resolved Hide resolved
@jleveque
Copy link
Contributor

@Junchao-Mellanox: Once this PR is merged, are we good to merge #5886?

@Junchao-Mellanox
Copy link
Collaborator Author

@Junchao-Mellanox: Once this PR is merged, are we good to merge #5886?

@keboliu I suppose you are working on the system health python3 migration, could you answer this comment?

@keboliu
Copy link
Collaborator

keboliu commented Dec 11, 2020

@Junchao-Mellanox: Once this PR is merged, are we good to merge #5886?

@keboliu I suppose you are working on the system health python3 migration, could you answer this comment?

generally, system-health has a dependency on platform API python3 lib, and when it ready system-health should be able to run, however, I see that system-health itself still has some issue in terms of string handling. left comments in another PR #5886

@jleveque jleveque merged commit 51c77b1 into sonic-net:master Dec 11, 2020
@Junchao-Mellanox Junchao-Mellanox deleted the mlnx-api-python3 branch December 15, 2020 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants