[image]: add --numeric_owner to perserve the original owner of the for docker filesystem #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
reviewed
May 24, 2017
installer/x86_64/install.sh
Outdated
| @@ -385,6 +385,7 @@ if [ "$install_env" != "sonic" ]; then | |||
| } | |||
| else | |||
| demo_mnt="/host" | |||
| TAR_EXTRA_OPTION="--numeric-owner" | |||
There was a problem hiding this comment.
Is there a reason to confine this option only to the SONiC-to-SONiC upgrade installation? I believe it should be safe for the ONIE install, as well. In fact, it's probably safer to use it on all installs. I can test an ONIE install using it just to confirm.
There was a problem hiding this comment.
onie is using another version of tar which does not support this option, but it works so it must using uid/gid by default.
There was a problem hiding this comment.
The ONIE versions installed on our dev devices are using BusyBox tar v1.20.2 which supports the option, however it is not listed in the help menu. See https://github.com/mozilla-b2g/busybox/blob/master/archival/tar.c#L796
marian-pritsak
approved these changes
May 24, 2017
qiluo-msft
approved these changes
May 24, 2017
jleveque
approved these changes
May 24, 2017
madhanmellanox
pushed a commit
to madhanmellanox/sonic-buildimage
that referenced
this pull request
Mar 23, 2020
…net#626) teammgrd will monitor configuration changes in CFG_LAG_TABLE_NAME and CFG_LAG_MEMBER_TABLE_NAME. It supports creation/removal of LAGs as well as membership changes of the LAG members. Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.