[build]: setup -t option in docker run correctly #6320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use bash -t test flag to check if input device is tty or not Signed-off-by: Guohan Lu <lguohan@gmail.com>
qiluo-msft
approved these changes
Dec 30, 2020
lguohan
added a commit
to lguohan/sonic-buildimage
that referenced
this pull request
Jan 20, 2021
use bash -t test flag to check if input device is tty or not Signed-off-by: Guohan Lu <lguohan@gmail.com>
lguohan
added a commit
to lguohan/sonic-buildimage
that referenced
this pull request
Jan 20, 2021
use bash -t test flag to check if input device is tty or not Signed-off-by: Guohan Lu <lguohan@gmail.com>
lguohan
added a commit
that referenced
this pull request
Jan 21, 2021
use bash -t test flag to check if input device is tty or not Signed-off-by: Guohan Lu <lguohan@gmail.com>
lguohan
added a commit
that referenced
this pull request
Jan 25, 2021
use bash -t test flag to check if input device is tty or not Signed-off-by: Guohan Lu <lguohan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use bash -t test flag to check if input device is tty or not
Signed-off-by: Guohan Lu lguohan@gmail.com
- Why I did it
TERM variable is not reliable way to detect input device is tty or not.
use bash -t test flag to check if input device is tty or not
- How I did it
use bash -t test flag to check if input device is tty or not
- How to verify it
test under both tty and non-tty env
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)