[minigraph.py]: Add peer switch hostname to device metadata #6405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
theasianpianist
requested review from
lguohan,
prsunny,
tahmed-dev and
vdahiya12
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
lguohan
approved these changes
Jan 9, 2021
|
retest vsimage please |
|
retest broadcom please |
|
retest mellanox please |
|
az pipeline passes |
daall
pushed a commit
that referenced
this pull request
Jan 11, 2021
To make the peer switch hostname easily accessible from config DB. Add peer_switch field to DEVICE_METADATA table Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
tahmed-dev
reviewed
Jan 11, 2021
| @@ -1178,6 +1178,10 @@ def parse_xml(filename, platform=None, port_config_file=None, asic_name=None, hw | |||
|
|
|||
| if bool(results['PEER_SWITCH']): | |||
| results['DEVICE_METADATA']['localhost']['subtype'] = 'DualToR' | |||
| if len(results['PEER_SWITCH'].keys()) > 1: | |||
There was a problem hiding this comment.
What is the underlying cause of the two peers entities? Is this coming from the GeminiPeeringLink property? If so, can we use the hostname from the graph to pick the correct peer?
There was a problem hiding this comment.
We should never have two peer entities, it would only occur if there were an error in the minigraph (if it had two of the peering link tags).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lawrence Lee lawlee@microsoft.com
- Why I did it
To make the peer switch hostname easily accessible from config DB
- How I did it
Add
peer_switchfield to DEVICE_METADATA table- How to verify it
Run the sonic-cfggen tests
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
