[sonic-platform-common] Enable unit tests during build for Python 3 package #6442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdahiya12
approved these changes
Jan 13, 2021
lguohan
pushed a commit
that referenced
this pull request
Jan 15, 2021
…ge (#6442) **- Why I did it** To enable running Pytest unit tests before building the Python 3 sonic-platform-common package **- How I did it** - Add Python 3 sonic-config-engine package as a dependency of Python 3 sonic-platform-common package (needed for both runtime and unit tests) - No longer disable unit tests when building Python 3 sonic-platform-common package
qiluo-msft
added
Request for 201911 Branch 
and removed
Request for 201911 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
To enable running Pytest unit tests before building the Python 3 sonic-platform-common package
- How I did it
- How to verify it
Build a SONiC image. Check sonic-platform-common Python 3 package build log and confirm unit tests were run
- Which release branch to backport (provide reason below if selected)