[warm boot finalizer] only wait for enabled components to reconcile #6454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define the component with its associated service. Only wait for components that have associated service enabled to reconcile during warm reboot. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
vaibhavhd
reviewed
Jan 14, 2021
| COMPONENT_LIST="" | ||
| for cp in ${CP_LIST}; do | ||
| service=${RECONCILE_COMPONENTS[${cp}]} | ||
| status=$(show feature status | grep "^${service}" | awk '{ print $2 }') |
There was a problem hiding this comment.
This logic depends on the raw output format of show feature status. If anything changes in this show api, awk might return some other column value. Can this rather be obtained directly from the DB?
$ redis-cli -n 4 HMGET "FEATURE|nat" state
1) "disabled"
$ redis-cli -n 4 HMGET "FEATURE|bgp" state
1) "enabled"
...
There was a problem hiding this comment.
good idea! changed. Thanks!
vaibhavhd
reviewed
Jan 14, 2021
| COMPONENT_LIST="" | ||
| for cp in ${CP_LIST}; do | ||
| service=${RECONCILE_COMPONENTS[${cp}]} | ||
| status=$(sonic-db-cli CONFIG_DB HGET "FEATURE|${service}" state) |
There was a problem hiding this comment.
The indentation looks a little off.
There was a problem hiding this comment.
yeah, editing on the target dut. vim setting is wrong there.
vaibhavhd
previously approved these changes
Jan 14, 2021
vaibhavhd
approved these changes
Jan 14, 2021
shi-su
approved these changes
Jan 15, 2021
|
retest mellanox please |
lguohan
pushed a commit
that referenced
this pull request
Jan 15, 2021
…6454) * [warm boot finalizer] only wait for enabled components to reconcile Define the component with its associated service. Only wait for components that have associated service enabled to reconcile during warm reboot. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
|
This is needed for 201911 branch too. Without this fix finalizer spends more than 5 minutes to finish warmboot. Letting finalizer wait for so long can cause:
Checked in 2700 device running 201911 with this fix added: |
abdosi
pushed a commit
that referenced
this pull request
Mar 31, 2022
…6454) * [warm boot finalizer] only wait for enabled components to reconcile Define the component with its associated service. Only wait for components that have associated service enabled to reconcile during warm reboot. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
Fix issue #6383
- How I did it
Define the component with its associated service. Only wait for components that have associated service enabled to reconcile during warm reboot.
Signed-off-by: Ying Xie ying.xie@microsoft.com
- How to verify it
Run warm reboot with the change (note that 'natsyncd' is no longer in the wait list:
/var/log/syslog.1:Jan 14 18:28:41.239710 str-7260cx3-acs-1 NOTICE root: WARMBOOT_FINALIZER : Wait for database to become ready...
/var/log/syslog.1:Jan 14 18:28:41.730254 str-7260cx3-acs-1 NOTICE root: WARMBOOT_FINALIZER : Database is ready...
/var/log/syslog.1:Jan 14 18:28:42.104362 str-7260cx3-acs-1 NOTICE root: WARMBOOT_FINALIZER : Restoring counters folder after warmboot...
/var/log/syslog.1:Jan 14 18:28:46.043684 str-7260cx3-acs-1 NOTICE root: WARMBOOT_FINALIZER : Waiting for components: ' neighsyncd bgp orchagent' to reconcile ...
/var/log/syslog:Jan 14 18:30:55.913965 str-7260cx3-acs-1 NOTICE root: WARMBOOT_FINALIZER : Tearing down control plane assistant ...
/var/log/syslog:Jan 14 18:30:59.123504 str-7260cx3-acs-1 NOTICE root: WARMBOOT_FINALIZER : Save in-memory database after warm reboot ...
/var/log/syslog:Jan 14 18:30:59.727347 str-7260cx3-acs-1 NOTICE root: WARMBOOT_FINALIZER : Finalizing warmboot...