Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minigraph.py]: Force /128 prefix for server IPv6 loopbacks #6524

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

theasianpianist
Copy link
Contributor

Signed-off-by: Lawrence Lee lawlee@microsoft.com

- Why I did it
Meet the requirement for the MUX_CABLE table that IPv6 loopbacks have a /128 prefix

- How I did it
Manually remove existing prefix by splitting IP string, then use Python's ipaddress module to implicitly add /128 prefix.

Note that this change only affects the MUX_CABLE table, all other tables continue to use the loopback address provided in minigraph.

- How to verify it
Run the sonic-config-engine tests

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
@lguohan
Copy link
Collaborator

lguohan commented Jan 21, 2021

az pipeline test passed.

@lguohan lguohan merged commit 8729fdc into sonic-net:master Jan 21, 2021
daall pushed a commit that referenced this pull request Jan 22, 2021
Meet the requirement for the MUX_CABLE table that IPv6 loopbacks have a /128 prefix

Note that this change only affects the MUX_CABLE table, all other tables continue to use the loopback address provided in minigraph.

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
@theasianpianist theasianpianist deleted the server-ipv6-lo branch May 13, 2021 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants