Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependency PYTHON2_SWSSCOMMON for docker-config-engine-stretch #6538

Merged
merged 1 commit into from
Jan 23, 2021

Conversation

qiluo-msft
Copy link
Collaborator

@qiluo-msft qiluo-msft commented Jan 23, 2021

- Why I did it
Otherwise all the docker image derived from docker-config-engine-stretch will have broken SONIC_CONFIG_ENGINE_PY2
The bug is introduced in #6406

- How I did it

- How to verify it

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@qiluo-msft
Copy link
Collaborator Author

Retest vsimage please

@lguohan
Copy link
Collaborator

lguohan commented Jan 23, 2021

azpl passed.

@lguohan lguohan merged commit 1c13340 into sonic-net:master Jan 23, 2021
@lguohan lguohan deleted the qiluo/stretchcommon branch January 23, 2021 08:25
lguohan pushed a commit that referenced this pull request Jan 24, 2021
…MMON (#6538)

Otherwise all the docker image derived from docker-config-engine-stretch will have broken SONIC_CONFIG_ENGINE_PY2
The bug is introduced in #6406
dflynn-Nokia added a commit to dflynn-Nokia/sonic-buildimage that referenced this pull request Jan 26, 2021
lguohan pushed a commit that referenced this pull request Jan 27, 2021
#6568)

This commit fixes a typo in the fix delivered in PR #6538

syncd fails on the armhf platform within sonic-config-engine/portconfig.py when importing the following
'from swsscommon.swsscommon import ConfigDBConnector'
lguohan pushed a commit that referenced this pull request Jan 28, 2021
#6568)

This commit fixes a typo in the fix delivered in PR #6538

syncd fails on the armhf platform within sonic-config-engine/portconfig.py when importing the following
'from swsscommon.swsscommon import ConfigDBConnector'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants