[Mellanox] Add hw-mgmt patch to support SDK OFFLINE event handling during ISSU #6550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in service firmware upgrade In order to prevent "mlxsw_minimal" driver accessing ASIC during in service firmware upgrade flow, SDK will raise "OFFLINE" 'udev' event at early beginning of such flow. When this event is received, hw-managemnet will remove "mlxsw_minimal" driver. There is no need to implement opposite "ONLINE" event, since this flow is ended up with "kexec". Signed-off-by: Kebo Liu <kebol@nvidia.com>
liat-grozovik
approved these changes
Jan 25, 2021
|
retest vsimage please |
|
retest vsimage |
|
/Azurepipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
retest vsimage please |
|
this is the same fix in 201911, which was approved and merge. so going a head and merging it as well. |
lguohan
pushed a commit
that referenced
this pull request
Jan 28, 2021
…in service firmware upgrade (#6550) During ISSU, "mlxsw_minimal" driver still trying to access firmware, in some cases FW could return some wrong critical threshold value which will cause switch shutdown. **- How I did it** In order to prevent "mlxsw_minimal" driver from accessing ASIC during ISSU, SDK will raise "OFFLINE" 'udev' event at the early beginning of such flow. When this event is received, hw-management will remove "mlxsw_minimal" driver. There is no need to implement the opposite "ONLINE" event since this flow is ended up with "kexec". **- How to verify it** repeatedly perform warm reboot, make sure there is no switch shutdown occurred.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Why I did it
During ISSU, "mlxsw_minimal" driver still trying to access firmware, in some cases FW could return some wrong critical threshold value which will cause switch shutdown.
- How I did it
In order to prevent "mlxsw_minimal" driver from accessing ASIC during ISSU, SDK will raise "OFFLINE" 'udev' event
at the early beginning of such flow. When this event is received, hw-management will remove "mlxsw_minimal" driver.
There is no need to implement the opposite "ONLINE" event since this flow is ended up with "kexec".
- How to verify it
repeatedly perform warm reboot, make sure there is no switch shutdown occurred.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)