-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci]: Add yaml for azure pipeline official build #6588
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change to .azure-pipelines/official.yml
/AzurePipelines run |
Commenter does not have sufficient privileges for PR 6588 in repo Azure/sonic-buildimage |
.azure-pipelines/cleanup.yml
Outdated
- script: | | ||
sudo kill -9 `sudo cat /var/run/march/docker.pid` || true | ||
sudo rm -f /var/run/march/docker.pid || true | ||
sudo rm -rf sonic-buildimage || sudo rm -rf ../sonic-buildimage || true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the code checked out as /agent/_work/1/s
there is no sonic-buildimage directory here.
should do sudo rm -rf target
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we publish
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if $(system.DefaultWorkingDirectory)/fsroot exist, publish maybe failed.
Signed-off-by: shilongliu <shilongliu@microsoft.com>
Signed-off-by: shilongliu <shilongliu@microsoft.com>
Signed-off-by: shilongliu <shilongliu@microsoft.com>
Signed-off-by: Shilong Liu <shilongliu@microsoft.com>
Signed-off-by: Shilong Liu <shilongliu@microsoft.com>
Signed-off-by: Shilong Liu <shilongliu@microsoft.com>
Signed-off-by: Shilong Liu <shilongliu@microsoft.com>
Signed-off-by: Shilong Liu <shilongliu@microsoft.com>
.azure-pipelines/build-template.yml
Outdated
- checkout: self | ||
submodules: recursive | ||
displayName: 'Checkout code' | ||
- script: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add clean=true in checkout, so this block can be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If fsroot exist, checkout with "clean=true" will fail because of permission.
Put clean steps together. Do cleaning job pre-build and post-build. This is more robust than build-in clean.
git submodule foreach --recursive git reset --hard | ||
git submodule update --init --recursive | ||
displayName: 'reset submodules' | ||
- script: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about to move the script from the template to the official.yml, only keep the most common part in the template, like init, checkout, publish, cleanup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
each plat form write their own script. this will make yml file more different with each other, like current Jenkinsfiles.
**- Why I did it** To support nightly build for master branch **- How to verify it** confirm from azure pipeline page.
- Why I did it
To support nightly build for master branch
- How I did it
- How to verify it
confirm from azure pipeline page.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)