Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[201811][pip2]: pin down pip to 20.3.3 #6593

Merged
merged 2 commits into from
Jan 30, 2021
Merged

Conversation

lguohan
Copy link
Collaborator

@lguohan lguohan commented Jan 28, 2021

With the release of pip21.0 (https://pypi.org/project/pip/#history) on branch
201811 stretch build is failing with below error logs:

As per https://pypi.org/project/pip/ pip21.0 does not not support python2
from Jan 2021. To fix this tag the pip to 20.3.3 version which was being used last
and is working fine.

Signed-off-by: Guohan Lu lguohan@gmail.com

- Why I did it
With the release of pip21.0 (https://pypi.org/project/pip/#history) on branch
201811 stretch build is failing with below error logs:

As per https://pypi.org/project/pip/ pip21.0 does not not support python2
from Jan 2021. To fix this tag the pip to 20.3.3 version which was being used last
and is working fine.

- How I did it

- How to verify it

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@jleveque jleveque changed the title [pip2]: pin down pip to 20.3.3 [201811][pip2]: pin down pip to 20.3.3 Jan 28, 2021
@qiluo-msft
Copy link
Collaborator

Do we have the same issue on master branch? If yes, fix master first?

@jleveque
Copy link
Contributor

jleveque commented Jan 28, 2021

Do we have the same issue on master branch? If yes, fix master first?

The branches have diverged too much to cherry-pick cleanly (e.g., docker-config-engine). I took care of this in most places in master while doing Python 3 migration work. However, it appears I missed build_debian.sh. I will open a separate PR for that.

Update: PR here: #6597

@skytreat
Copy link

Do we have the same issue on master branch? If yes, fix master first?

I do not think so since the PR build on master branch should have blocked the faulted commits

With the release of pip21.0 (https://pypi.org/project/pip/#history) on branch
201811 stretch build is failing with below error logs:

As per https://pypi.org/project/pip/ pip21.0 does not not support python2
from Jan 2021. To fix this tag the pip to 20.3.3 version which was being used last
and is working fine.

Signed-off-by: Guohan Lu <lguohan@gmail.com>
Signed-off-by: Guohan Lu <lguohan@gmail.com>
@lguohan lguohan marked this pull request as ready for review January 30, 2021 13:05
@lguohan lguohan merged commit db81349 into sonic-net:201811 Jan 30, 2021
@lguohan lguohan deleted the pip branch January 30, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants