Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[port_config.ini] 7050CX3-32S-C32: Remove unused 10G ports and update speed #6638

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

vaibhavhd
Copy link
Contributor

port_config.ini for HWSKU Arista-7050CX3-32S-C32 has missing speed column and duplicated lanes.
The incorrect speed causes issues in Orchagent RESTARTCHECK as the below task remains as the remaining item during swss shutdown.

- Why I did it
Fixes: #6569

- How I did it
Updated port_config.ini file with speed, and removed duplicated lanes.

- How to verify it
Generated new minigraph, and installed it on a 7050CX3 device, the RESTARTCHECK passes and warm-reboot proceeds.

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@vaibhavhd vaibhavhd requested a review from yxieca February 2, 2021 07:27
@vaibhavhd vaibhavhd requested a review from jleveque as a code owner February 2, 2021 07:27
@lguohan
Copy link
Collaborator

lguohan commented Feb 2, 2021

do we have the same problem as d48c8 sku on this platform?

@vaibhavhd
Copy link
Contributor Author

do we have the same problem as d48c8 sku on this platform?

Arista-7050CX3-32S-D48C8 does not have the same problem. That SKU has portconfig.ini with speed defined as expected, and the 10G ports not mentioned:
https://github.com/Azure/sonic-buildimage/blob/master/device/arista/x86_64-arista_7050cx3_32s/Arista-7050CX3-32S-D48C8/port_config.ini

@lguohan lguohan merged commit 580666a into sonic-net:master Feb 2, 2021
Ethernet116 113,114,115,116 Ethernet30/1 30
Ethernet120 121,122,123,124 Ethernet31/1 31
Ethernet124 125,126,127,128 Ethernet32/1 32
Ethernet128 129 Ethernet33 33
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it help if we add Ethernet128, Ethernet129 with speed 10G in port-config.ini? I mean why remove altogether?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried with updating just the speed and not removing the ports and the issue is not seen anymore. There is another issue, however - the original port_config.ini had duplicated lane 128 on two ports.
We can add 10G ports back again when @Staphylo confirms what should be the correct lane allocation.

lguohan pushed a commit that referenced this pull request Feb 3, 2021
…6638)

port_config.ini for HWSKU Arista-7050CX3-32S-C32 has missing speed column and duplicated lanes.
The incorrect speed causes issues in Orchagent RESTARTCHECK as the below task remains as the remaining item during swss shutdown.
deran1980 pushed a commit to deran1980/sonic-buildimage that referenced this pull request Feb 4, 2021
…onic-net#6638)

port_config.ini for HWSKU Arista-7050CX3-32S-C32 has missing speed column and duplicated lanes.
The incorrect speed causes issues in Orchagent RESTARTCHECK as the below task remains as the remaining item during swss shutdown.
@vaibhavhd vaibhavhd deleted the 7050cx3-port-config-fix branch February 22, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

master->master warm reboot fails because of pending tasks in the queue
4 participants