Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Celestica][haliburton][cp210x] modprobe cp210x to ensure the driver can be load properly #6715

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

Blueve
Copy link
Contributor

@Blueve Blueve commented Feb 8, 2021

- Why I did it

This PR is to fix issue: #6603
The CP210x driver not attached properly after first login (cold-plug), lsusb and dmesg shown that the usb devices has been recognized but driver is missing.

The CP210x driver is embedded in Kernel, so we don't need install it manually.

- How I did it

Add modprode cp210x to haliburton service initialization stage.

- How to verify it

  • Build image without any change and reproduce the issue
  • Build image with current change and see if the issue fixed

After this change, all driver are attached and udev rule is working well

Debian GNU/Linux 10 sonic ttyS1

sonic login: admin
Password: 
Linux sonic 4.19.0-9-2-amd64 #1 SMP Debian 4.19.118-2+deb10u1 (2020-06-07) x86_64
You are on
  ____   ___  _   _ _  ____
 / ___| / _ \| \ | (_)/ ___|
 \___ \| | | |  \| | | |
  ___) | |_| | |\  | | |___
 |____/ \___/|_| \_|_|\____|

-- Software for Open Networking in the Cloud --

Unauthorized access and/or use are prohibited.
All access and/or use are subject to monitoring.

Help:    http://azure.github.io/SONiC/

admin@sonic:~$ ls /dev/tty*
/dev/tty    /dev/tty26  /dev/tty44  /dev/tty62     /dev/ttyUSB19  /dev/ttyUSB37
/dev/tty0   /dev/tty27  /dev/tty45  /dev/tty63     /dev/ttyUSB2   /dev/ttyUSB38
/dev/tty1   /dev/tty28  /dev/tty46  /dev/tty7      /dev/ttyUSB20  /dev/ttyUSB39
/dev/tty10  /dev/tty29  /dev/tty47  /dev/tty8      /dev/ttyUSB21  /dev/ttyUSB4
/dev/tty11  /dev/tty3   /dev/tty48  /dev/tty9      /dev/ttyUSB22  /dev/ttyUSB40
/dev/tty12  /dev/tty30  /dev/tty49  /dev/ttyS0     /dev/ttyUSB23  /dev/ttyUSB41
/dev/tty13  /dev/tty31  /dev/tty5   /dev/ttyS1     /dev/ttyUSB24  /dev/ttyUSB42
/dev/tty14  /dev/tty32  /dev/tty50  /dev/ttyS2     /dev/ttyUSB25  /dev/ttyUSB43
/dev/tty15  /dev/tty33  /dev/tty51  /dev/ttyS3     /dev/ttyUSB26  /dev/ttyUSB44
/dev/tty16  /dev/tty34  /dev/tty52  /dev/ttyUSB0   /dev/ttyUSB27  /dev/ttyUSB45
/dev/tty17  /dev/tty35  /dev/tty53  /dev/ttyUSB1   /dev/ttyUSB28  /dev/ttyUSB46
/dev/tty18  /dev/tty36  /dev/tty54  /dev/ttyUSB10  /dev/ttyUSB29  /dev/ttyUSB47
/dev/tty19  /dev/tty37  /dev/tty55  /dev/ttyUSB11  /dev/ttyUSB3   /dev/ttyUSB5
/dev/tty2   /dev/tty38  /dev/tty56  /dev/ttyUSB12  /dev/ttyUSB30  /dev/ttyUSB6
/dev/tty20  /dev/tty39  /dev/tty57  /dev/ttyUSB13  /dev/ttyUSB31  /dev/ttyUSB7
/dev/tty21  /dev/tty4   /dev/tty58  /dev/ttyUSB14  /dev/ttyUSB32  /dev/ttyUSB8
/dev/tty22  /dev/tty40  /dev/tty59  /dev/ttyUSB15  /dev/ttyUSB33  /dev/ttyUSB9
/dev/tty23  /dev/tty41  /dev/tty6   /dev/ttyUSB16  /dev/ttyUSB34
/dev/tty24  /dev/tty42  /dev/tty60  /dev/ttyUSB17  /dev/ttyUSB35
/dev/tty25  /dev/tty43  /dev/tty61  /dev/ttyUSB18  /dev/ttyUSB36
admin@sonic:~$ ls /dev/C0*
/dev/C0-1   /dev/C0-17  /dev/C0-24  /dev/C0-31  /dev/C0-39  /dev/C0-46
/dev/C0-10  /dev/C0-18  /dev/C0-25  /dev/C0-32  /dev/C0-4   /dev/C0-47
/dev/C0-11  /dev/C0-19  /dev/C0-26  /dev/C0-33  /dev/C0-40  /dev/C0-48
/dev/C0-12  /dev/C0-2   /dev/C0-27  /dev/C0-34  /dev/C0-41  /dev/C0-5
/dev/C0-13  /dev/C0-20  /dev/C0-28  /dev/C0-35  /dev/C0-42  /dev/C0-6
/dev/C0-14  /dev/C0-21  /dev/C0-29  /dev/C0-36  /dev/C0-43  /dev/C0-7
/dev/C0-15  /dev/C0-22  /dev/C0-3   /dev/C0-37  /dev/C0-44  /dev/C0-8
/dev/C0-16  /dev/C0-23  /dev/C0-30  /dev/C0-38  /dev/C0-45  /dev/C0-9

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

This is a system regression fix for console switch.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@Blueve
Copy link
Contributor Author

Blueve commented Feb 9, 2021

Azure.sonic-buildimage (Test kvmtest-t0) failed continually, seems like the test itself is broken

@Blueve Blueve changed the title [Celestica][haliburton][cp210x] modprobe cp210x to ensure the driver loaded properly [Celestica][haliburton][cp210x] modprobe cp210x to ensure the driver can be load properly Feb 9, 2021
@lguohan
Copy link
Collaborator

lguohan commented Feb 10, 2021

why is this not needed in 201911 image?

@lguohan lguohan merged commit d8fe592 into sonic-net:master Feb 10, 2021
@Blueve
Copy link
Contributor Author

Blueve commented Feb 12, 2021

why is this not needed in 201911 image?

This issue cannot be reproduced in 201911 image.

@lguohan
Copy link
Collaborator

lguohan commented Feb 13, 2021

what is the difference here?

daall pushed a commit that referenced this pull request Feb 16, 2021
…loaded properly (#6715)

This PR is to fix issue: #6603
The CP210x driver not attached properly after first login (cold-plug), lsusb and dmesg shown that the usb devices has been recognized but driver is missing.
@sandycelestica
Copy link
Contributor

Verified this change under haliburton it works well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Celestica][E1031] USB tty devices not listed under \dev after SONiC installed
4 participants