-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable snmpd native ipCidrRouteTable implementation #675
Merged
lguohan
merged 4 commits into
sonic-net:master
from
qiluo-msft:qiluo/snmp-IpCidrRouteTable
Jun 7, 2017
Merged
Disable snmpd native ipCidrRouteTable implementation #675
lguohan
merged 4 commits into
sonic-net:master
from
qiluo-msft:qiluo/snmp-IpCidrRouteTable
Jun 7, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
can you elaborate the reason, why disable? |
can you modify your commit message to include the reasons. |
The SNMP subagent implements ipCidrRouteTable. If there is no nexthops for default route, ie. switch isolated, the SNMP subagent will response 'no instance'. Then snmpd will response kernel routes, which include non-front panel interfaces. To remove snmpd native implementation, we only expose SNMP subagent's implementation.
Modified as you requested. |
lguohan
approved these changes
Jun 6, 2017
3 tasks
lguohan
pushed a commit
that referenced
this pull request
Oct 26, 2020
Advance sonic-swss-common submodule by adding the following commits 3ec30ef Deprecate RedisClient and remove unused header file (#399) 165a679 Schema update for BGP internal neighbor table (#389) 262e330 Fix SonicV2Connector interfaces (#396) Advance sonic-sairedis submodule by adding the following commits bc3e044 [Sai]: Change Sai::set log to level INFO (#680) b16bc8b Clean code: remove unused header file (#678) 40439b4 [syncd] Remove depreacated dependency on swss::RedisClient (#681) 1b6fc2e [syncd] Add supports of bulk api in syncd (#656) a9f69c1 [syncd] Add to handle FDB MOVE notification (#670) c7ef5e9 [gbsyncd] exit with zero when platform has no gearbox (#676) 57228fd [gbsyncd]: add missing python dependency (#675) 02a57a6 [vs] Add CRM SAI attributes to virtual switch interface (#673) 609445a fix boot type for fast boot (#674) 1325cdf Add support for saiplayer bulk API and add performance timers (#666) 1d84b90 Add ZeroMQ communication channel between sairedis and syncd (#659) 017056a Support System ports config (#657) 0f3668f Enable fabric counter for syncd's FlexCounter (#669)
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
…ic-net#5703) Advance sonic-swss-common submodule by adding the following commits 3ec30ef Deprecate RedisClient and remove unused header file (sonic-net#399) 165a679 Schema update for BGP internal neighbor table (sonic-net#389) 262e330 Fix SonicV2Connector interfaces (sonic-net#396) Advance sonic-sairedis submodule by adding the following commits bc3e044 [Sai]: Change Sai::set log to level INFO (sonic-net#680) b16bc8b Clean code: remove unused header file (sonic-net#678) 40439b4 [syncd] Remove depreacated dependency on swss::RedisClient (sonic-net#681) 1b6fc2e [syncd] Add supports of bulk api in syncd (sonic-net#656) a9f69c1 [syncd] Add to handle FDB MOVE notification (sonic-net#670) c7ef5e9 [gbsyncd] exit with zero when platform has no gearbox (sonic-net#676) 57228fd [gbsyncd]: add missing python dependency (sonic-net#675) 02a57a6 [vs] Add CRM SAI attributes to virtual switch interface (sonic-net#673) 609445a fix boot type for fast boot (sonic-net#674) 1325cdf Add support for saiplayer bulk API and add performance timers (sonic-net#666) 1d84b90 Add ZeroMQ communication channel between sairedis and syncd (sonic-net#659) 017056a Support System ports config (sonic-net#657) 0f3668f Enable fabric counter for syncd's FlexCounter (sonic-net#669)
AidanCopeland
pushed a commit
to Metaswitch/sonic-buildimage
that referenced
this pull request
Apr 14, 2022
Signed-off-by: Guohan Lu <lguohan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SNMP subagent implements ipCidrRouteTable. If there is no nexthops for default route, ie. switch isolated, the SNMP subagent will response 'no instance'. Then snmpd will response kernel routes, which include non-front panel interfaces. To remove snmpd native implementation, we only expose SNMP subagent's implementation.