[teamd]: Increase wait timeout for teamd docker stop to clean Port channels. #6757
Conversation
Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com>
|
@abdosi please review. we believe this is needed for production |
|
@shlomibitton please have a look at this: #6648 |
|
@judyjoseph can you review/approve this ? |
@shlomibitton This PR (#6648) was introduced to fix #6503. Have you verified this takes care of this scenario , would be great if you add the verification details in the description. Additionally I was not able to repro this issue #6199 in 201911, were you seeing it ? |
|
Hi
Yes we did, we were able to reproduce it when we have a ~80 port channel and each with IP address.
It was also verified on the reproduction environment and found to be working.
From: judyjoseph <notifications@github.com>
Sent: Tuesday, February 16, 2021 10:06 PM
To: Azure/sonic-buildimage <sonic-buildimage@noreply.github.com>
Cc: Liat Grozovik <liatg@nvidia.com>; Comment <comment@noreply.github.com>
Subject: Re: [Azure/sonic-buildimage] [teamd]: Increase wait timeout for teamd docker stop to clean Port channels. (#6757)
@shlomibitton<https://github.com/shlomibitton> please have a look at this: #6648<#6648>
@shlomibitton<https://github.com/shlomibitton> This PR (#6648<#6648>) was introduced to fix #6503<#6503>. Have you verified this takes care of this scenario , would be great if you add the verification details in the description.
Additionally I was not able to repro this issue #6199<#6199> in 201911, were you seeing it ?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#6757 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKTABA2KCYTHITDTRE52GWDS7LF35ANCNFSM4XNTA4MQ>.
|
|
@nazariig @judyjoseph this PR #6648 is basically does the same thing only for teamd docker. |
There was a problem hiding this comment.
@shlomibitton Thanks for pointing this out. Would prefer to increase timeout specific to teamd docker as done in #6648. Increasing the timeout could change behavior of time sensitive use cases like warm boot.
|
@judyjoseph is there a PR like #6648 already in master/202012 (thus closing this one should be done) or you wish this one to be modified ? |
|
closing this. |
Signed-off-by: Shlomi Bitton shlomibi@nvidia.com
- Why I did it
Following this PR #6537
Increase wait timeout for teamd docker stop to clean Port channels.
Fixes #6199
- How I did it
Changed the container timeout on stop() function for container template.
- How to verify it
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)