[barefoot][sonic-platform] Refactor sfp.py #6770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>
vboykox
changed the title
jleveque
previously approved these changes
Feb 11, 2021
vboykox
force-pushed
the
refactor-sfp
branch
from
26f42df
to
8988d51
Compare
jleveque
suggested changes
Feb 11, 2021
platform/barefoot/sonic-platform-modules-bfn-montara/sonic_platform/sfp.py
Outdated
Show resolved
Hide resolved
vboykox
force-pushed
the
refactor-sfp
branch
from
8988d51
to
8d35da9
Compare
jleveque
approved these changes
Feb 11, 2021
daall
pushed a commit
that referenced
this pull request
Feb 16, 2021
Use separate file for each sfp eeprom operation Signed-off-by: Volodymyr Boyko <volodymyrx.boiko@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Volodymyr Boyko volodymyrx.boiko@intel.com
Why I did it
Use separate file for each sfp eeprom operation
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)