Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dockerbase]: remove apt-get clean #685

Merged
merged 1 commit into from
Jun 8, 2017
Merged

Conversation

lguohan
Copy link
Collaborator

@lguohan lguohan commented Jun 8, 2017

(qiluo-msft added)
The debian jessie image updated recently (https://github.com/debuerreotype/docker-debian-artifacts/blob/0dcb9a06b2fcf9fdb416dc558db6f7b84cb6ab01/jessie/rootfs.tar.xz) and brought breaking change.
The path /var/cache/apt/archives/ is missing, and later 'apt-get clean' will fail with

E: Could not open lock file /var/cache/apt/archives/lock - open (2: No such file or directory)
E: Unable to lock the download directory

We found that 'apt-get update' will create the missing directory and files, so simple remove the 'apt-clean' to workaround this bug.

@lguohan lguohan merged commit bc5bca6 into sonic-net:master Jun 8, 2017
@YonatanPitz
Copy link
Contributor

I took the new commit and still I get this error when trying to build slave image:

E: Could not open lock file /var/cache/apt/archives/lock - open (2: No such file or directory)
E: Unable to lock the download directory

dockers/docker-base/Dockerfile.j2:

COPY ["dpkg_01_drop", "/etc/dpkg/dpkg.cfg.d/01_drop"]
RUN apt-get update

## Pre-install fundamental packages

@qiluo-msft
Copy link
Collaborator

@YonatanPitz Could you double check the log file (target/docker-base.gz.log). Below is from our build server.

Sending build context to Docker daemon 94.43 MB

Step 1/15 : FROM debian:jessie
jessie: Pulling from library/debian
ef0380f84d05: Pulling fs layer
ef0380f84d05: Verifying Checksum
ef0380f84d05: Download complete
ef0380f84d05: Pull complete
Digest: sha256:e283dc7bdfe4df3672ba561cf50022528c493cc5800e80670ca47315aad6a5de
Status: Downloaded newer image for debian:jessie
 ---> a25c1eed1c6f
Step 2/15 : RUN find /usr/share/doc -depth \( -type f -o -type l \) ! -name copyright | xargs rm || true
 ---> Running in 633c57c80ebb
 ---> b0bcc602ed96
Removing intermediate container 633c57c80ebb
Step 3/15 : RUN while [ -n "$(find /usr/share/doc -depth -type d -empty -print -exec rmdir {} +)" ]; do :; done
 ---> Running in 54833d72380a
 ---> 00287066d022
Removing intermediate container 54833d72380a
Step 4/15 : RUN rm -rf                   /usr/share/man/*         /usr/share/groff/*       /usr/share/info/*        /usr/share/lintian/*     /usr/share/linda/*       /var/cache/man/*         /usr/share/locale/*
 ---> Running in f75568898c0d
 ---> 46728315bdd2
Removing intermediate container f75568898c0d
Step 5/15 : ENV DEBIAN_FRONTEND noninteractive
 ---> Running in f96c5e639c49
 ---> 1b17b5862e72
Removing intermediate container f96c5e639c49
Step 6/15 : COPY sources.list /etc/apt/sources.list
 ---> 2d90249d4c1d
Removing intermediate container 4651570232bd
Step 7/15 : COPY dpkg_01_drop /etc/dpkg/dpkg.cfg.d/01_drop
 ---> a45142a40127
Removing intermediate container 2a1d93ae8ac9
Step 8/15 : RUN apt-get update
 ---> Running in 0daf0609f5e3
Ign http://debian-archive.trafficmanager.net jessie InRelease
Get:1 http://debian-archive.trafficmanager.net jessie/updates InRelease [63.1 kB]
Get:2 http://debian-archive.trafficmanager.net jessie Release.gpg [2373 B]
Get:3 http://debian-archive.trafficmanager.net jessie Release [148 kB]

@YonatanPitz
Copy link
Contributor

YonatanPitz commented Jun 10, 2017

@qiluo-msft
Hi,
I have followed the instruction in README.md, and when I got to the point of:
sudo make configure PLATFORM=p4
I've got this error.

no target dir was created and so no log, but the stdout ouput is:

> Image sonic-slave-root:82e970f142 not found. Building...
> Sending build context to Docker daemon 9.216 kB
> 
> Step 1 : FROM debian:jessie
>  ---> a25c1eed1c6f
> Step 2 : MAINTAINER johnar@microsoft.com
>  ---> Running in 8f60ac5edc17
>  ---> c0e8ee3cf8f0
> Removing intermediate container 8f60ac5edc17
> Step 3 : RUN echo "deb http://debian-archive.trafficmanager.net/debian/ jessie main contrib non-free" >> /etc/apt/sources.list &&         echo "deb-src http://debian-archive.trafficmanager.net/debian/ jessie main contrib non-free" >> /etc/apt/sources.list &&         echo "deb http://debian-archive.trafficmanager.net/debian-security/ jessie/updates main contrib non-free" >> /etc/apt/sources.list &&         echo "deb-src http://debian-archive.trafficmanager.net/debian-security/ jessie/updates main contrib non-free" >> /etc/apt/sources.list &&         echo 'deb http://debian-archive.trafficmanager.net/debian jessie-backports main' >> /etc/apt/sources.list
>  ---> Running in 8d0a95e8288f
>  ---> 01be4ca74a8a
> Removing intermediate container 8d0a95e8288f
> Step 4 : ENV DEBIAN_FRONTEND noninteractive
>  ---> Running in 47153c8e78f3
>  ---> b5c827b05fc7
> Removing intermediate container 47153c8e78f3
> Step 5 : RUN apt-get clean && apt-get update && apt-get install -y         apt-utils         default-jre-headless         openssh-server         curl         wget         unzip         git         build-essential         libtool         lintian         sudo         dh-make         dh-exec         kmod         libtinyxml2-2         libboost-program-options1.55-dev         libtinyxml2-dev         python         python-pip         libncurses5-dev         texinfo         dh-autoreconf         python3-pip         doxygen         devscripts         git-buildpackage         perl-modules         libswitch-perl         dh-systemd         libreadline-dev         texlive-latex-base         texlive-generic-recommended         texlive-fonts-recommended         libpam0g-dev         libpam-dev         libcap-dev         imagemagick         ghostscript         groff         libpcre3-dev         gawk         chrpath         libc-ares-dev         hardening-wrapper         libsnmp-dev         libjson0         libjson0-dev         libsystemd-dev         python-ipaddr         cdbs         libxml-simple-perl         graphviz         aspell         bc         fakeroot         build-essential         devscripts         quilt         stgit         module-assistant         gem2deb         libboost-all-dev         libevent-dev         libglib2.0-dev         libqt4-dev         python-all-dev         python-twisted         php5-dev         phpunit         libbit-vector-perl         openjdk-7-jdk         javahelper         maven-debian-helper         ant         libmaven-ant-tasks-java         libhttpclient-java         libslf4j-java         libservlet3.1-java         qt5-default         libpcre3         libpcre3-dev         byacc         flex         libglib2.0-dev         bison         expat         libexpat1-dev         dpatch         libdb-dev         iptables-dev         swig         libtool-bin         libxml2-dev         cpio         squashfs-tools         zip         linux-compiler-gcc-4.8-x86         linux-kbuild-3.16         libdaemon-dev         libdbus-1-dev         libjansson-dev         libpcap-dev         dnsutils         libusb-dev         augeas-tools         libyaml-dev         libevent-dev         libjudy-dev         libedit-dev         libnanomsg-dev         python-stdeb         libjemalloc-dev         dkms         sharutils         libncursesw5-dev         libbz2-dev         liblzma-dev         libgdbm-dev         tk-dev         blt-dev         libmpdec-dev         libbluetooth-dev         locales         libsqlite3-dev         libgpm2         time         net-tools         xvfb         python-sphinx         python3-sphinx         cppcheck         clang         pylint         python-pytest         gcovr         python-pytest=2.6.3*         python-pytest-cov         python-parse         libmysqlclient-dev         libmysqld-dev         libperl-dev         libpci-dev         libpci3         libsensors4         libsensors4-dev         libwrap0-dev         docutils-common         libjs-sphinxdoc         libjs-underscore         python-docutils         python-jinja2         python-markupsafe         python-pygments         python-roman         python-sphinx         sphinx-common         python3-sphinx         python-lxml         python-jinja2         python-netaddr         python-ipaddr         python-yaml         procmail         libgtest-dev         cmake         && apt-get -y build-dep linux         && apt-get -yt jessie-backports install         golang-go         golang-github-golang-mock-dev         && pip install         ctypesgen         crc16         j2cli         pyangbind
>  ---> Running in d936146e85d7
> �[91mE: Could not open lock file /var/cache/apt/archives/lock - open (2: No such file or directory)
> E: Unable to lock the download directory
> �[0mMakefile:47: recipe for target 'configure' failed

Thank you,
Yonatan

@qiluo-msft
Copy link
Collaborator

Oh, you found a new bug in https://github.com/Azure/sonic-buildimage/blob/master/sonic-slave/Dockerfile.
The 'apt-get clean' should also be removed because recent update in 'debian:jessie' upstream image.
Sorry for the inconvenience, we will check and fix soon.

@qiluo-msft
Copy link
Collaborator

Follow up with #693

@lguohan lguohan deleted the dockerbase1 branch November 6, 2017 04:36
lguohan added a commit to lguohan/sonic-buildimage that referenced this pull request Nov 18, 2018
sonic-sairedis

* 398d24a 2018-11-16 |  Add comments aspell check (sonic-net#382) (master) [Kamil Cudnik]
* 08fccb0 2018-11-15 | Add buffer pool logic and unittests (sonic-net#381) [Kamil Cudnik]
* 4d5a7bb 2018-11-15 | Rebuild VS local metadata on warm boot (sonic-net#380) [Kamil Cudnik]
* b011f3d 2018-11-15 | Add cold discovered oids (sonic-net#379) [Kamil Cudnik]
* 11c386e 2018-11-14 | [syncd] always log ASIC operations performed after warm restart (sonic-net#378) [Ying Xie]
* ebb9b7a 2018-11-14 | [syncd] provide docker name when checking warm restart (sonic-net#377) [Ying Xie]
* 72d8cc3 2018-11-12 | Add warm boot support for virtual switch (sonic-net#374) [Kamil Cudnik]
* 333c5ff 2018-11-11 | Refactor sairedis (sonic-net#375) [Kamil Cudnik]

sonic-utilities

* c6b4fe7 2018-11-15 | Adding bgp's warmrestart timer and on-off knob (sonic-net#378) (HEAD, origin/master, origin/HEAD, master) [Rodny Molina]
* 45d85c9 2018-11-15 | [warm boot] move warm reboot/fast reboot knowledge to syncd service script (sonic-net#372) [Ying Xie]

sonic-swss
* 067928d 2018-11-17 | [aclorch]: Use the Observer class to listen to port changes (sonic-net#689) (HEAD, origin/master, origin/HEAD) [Shuotian Cheng]
* d7d887a 2018-11-15 | [test]: Remove deprecated TODO comment (sonic-net#688) (master) [Shuotian Cheng]
* b42710a 2018-11-15 | [teammgrd]: Check if port is enslaved on all conditions (sonic-net#687) [Shuotian Cheng]
* 75972e7 2018-11-13 | Restore port oper status form appDB port table during restore phase o… (sonic-net#683) [Jipan Yang]
* 48c3bfb 2018-11-13 | [WarmStart]: Use right docker name for the teammgrd checkWarmStart (sonic-net#685) [pavel-shirshov]
* 6292786 2018-11-13 | [teammgrd]: Add kernel master check for port before enslaving (sonic-net#681) [Shuotian Cheng]
* a42ef4c 2018-11-12 | Adjust schema to match bgp warm-restart timer interval (sonic-net#682) [Rodny Molina]
* dc2ff77 2018-11-12 | [portsorch]: Move status comparison outside updatePortOperStatus function (sonic-net#679) [Shuotian Cheng]

Signed-off-by: Guohan Lu <gulv@microsoft.com>
lguohan added a commit that referenced this pull request Nov 18, 2018
sonic-sairedis

* 398d24a 2018-11-16 |  Add comments aspell check (#382) (master) [Kamil Cudnik]
* 08fccb0 2018-11-15 | Add buffer pool logic and unittests (#381) [Kamil Cudnik]
* 4d5a7bb 2018-11-15 | Rebuild VS local metadata on warm boot (#380) [Kamil Cudnik]
* b011f3d 2018-11-15 | Add cold discovered oids (#379) [Kamil Cudnik]
* 11c386e 2018-11-14 | [syncd] always log ASIC operations performed after warm restart (#378) [Ying Xie]
* ebb9b7a 2018-11-14 | [syncd] provide docker name when checking warm restart (#377) [Ying Xie]
* 72d8cc3 2018-11-12 | Add warm boot support for virtual switch (#374) [Kamil Cudnik]
* 333c5ff 2018-11-11 | Refactor sairedis (#375) [Kamil Cudnik]

sonic-utilities

* c6b4fe7 2018-11-15 | Adding bgp's warmrestart timer and on-off knob (#378) (HEAD, origin/master, origin/HEAD, master) [Rodny Molina]
* 45d85c9 2018-11-15 | [warm boot] move warm reboot/fast reboot knowledge to syncd service script (#372) [Ying Xie]

sonic-swss
* 067928d 2018-11-17 | [aclorch]: Use the Observer class to listen to port changes (#689) (HEAD, origin/master, origin/HEAD) [Shuotian Cheng]
* d7d887a 2018-11-15 | [test]: Remove deprecated TODO comment (#688) (master) [Shuotian Cheng]
* b42710a 2018-11-15 | [teammgrd]: Check if port is enslaved on all conditions (#687) [Shuotian Cheng]
* 75972e7 2018-11-13 | Restore port oper status form appDB port table during restore phase o… (#683) [Jipan Yang]
* 48c3bfb 2018-11-13 | [WarmStart]: Use right docker name for the teammgrd checkWarmStart (#685) [pavel-shirshov]
* 6292786 2018-11-13 | [teammgrd]: Add kernel master check for port before enslaving (#681) [Shuotian Cheng]
* a42ef4c 2018-11-12 | Adjust schema to match bgp warm-restart timer interval (#682) [Rodny Molina]
* dc2ff77 2018-11-12 | [portsorch]: Move status comparison outside updatePortOperStatus function (#679) [Shuotian Cheng]

Signed-off-by: Guohan Lu <gulv@microsoft.com>
madhanmellanox pushed a commit to madhanmellanox/sonic-buildimage that referenced this pull request Mar 23, 2020
…onic-net#685)

* Pospone QueueMap initialization until activation of counters

* Generate queue maps only for front panel ports

* Use right docker name for the teammgrd checkWarmStart

* Use -o flag for WE mode
kcudnik added a commit that referenced this pull request Dec 5, 2020
[sairedis] Advance sairedis pointer to support cmd zmq flag

[meta] Use memcpy instead of cast to prevent strict-aliasing error (#723)
[vslib]Add MACsec forward and filters to HostInterfaceInfo (#719)
[vslib] Add StateBase function for MACsec (#717)
Add support for default zmq synchronous mode flag (#711)
[syncd] Code clean (#720)
[sairedis] Remove custom bulk fdb methods (#710)
[vslib]Add MACsec Filters (#713)
[vslib]Add MACsec Forwarder (#714)
[vslib]Add MACsec Manager (#715)
Add helper functions, findObjects and dumpObject (#716)
Code clean refactor (#712)
[vslib] Fix CorePortIndexMap log line (#708)
[meta] Use custom hash in SaiObjectCollection (#709)
Fix LGTM localtime function warnings (#707)
[vs] VoQ Switch objects initialization - Local Port OID mapping to System Ports (#703)
Code style refactor (#705)
[vs] Initialization of VOQ switch objects (#702)
[vs] SAI support for VOQ switches - Switch State Initialization (#701)
Add MACsec meta methods (#704)
[vs] SAI support for VOQ switches (#698)
[vs] SAI support for VOQ switches - Core Port Index Map File parser (#700)
[vs] SAI support for VoQ switch - Core Port Index Map Container (#699)
[syncd][sairedis] Change pub/sub model to push/pull in zmq notification (#695)
[syncd] Use lua script to update db when using bulk api (#690)
[syncd] Fix bulk api object type for next hop group members (#685)
Add FlexCounter for MACsec SA (#684)
santhosh-kt pushed a commit to santhosh-kt/sonic-buildimage that referenced this pull request Feb 25, 2021
…t#6064)

[sairedis] Advance sairedis pointer to support cmd zmq flag

[meta] Use memcpy instead of cast to prevent strict-aliasing error (sonic-net#723)
[vslib]Add MACsec forward and filters to HostInterfaceInfo (sonic-net#719)
[vslib] Add StateBase function for MACsec (sonic-net#717)
Add support for default zmq synchronous mode flag (sonic-net#711)
[syncd] Code clean (sonic-net#720)
[sairedis] Remove custom bulk fdb methods (sonic-net#710)
[vslib]Add MACsec Filters (sonic-net#713)
[vslib]Add MACsec Forwarder (sonic-net#714)
[vslib]Add MACsec Manager (sonic-net#715)
Add helper functions, findObjects and dumpObject (sonic-net#716)
Code clean refactor (sonic-net#712)
[vslib] Fix CorePortIndexMap log line (sonic-net#708)
[meta] Use custom hash in SaiObjectCollection (sonic-net#709)
Fix LGTM localtime function warnings (sonic-net#707)
[vs] VoQ Switch objects initialization - Local Port OID mapping to System Ports (sonic-net#703)
Code style refactor (sonic-net#705)
[vs] Initialization of VOQ switch objects (sonic-net#702)
[vs] SAI support for VOQ switches - Switch State Initialization (sonic-net#701)
Add MACsec meta methods (sonic-net#704)
[vs] SAI support for VOQ switches (sonic-net#698)
[vs] SAI support for VOQ switches - Core Port Index Map File parser (sonic-net#700)
[vs] SAI support for VoQ switch - Core Port Index Map Container (sonic-net#699)
[syncd][sairedis] Change pub/sub model to push/pull in zmq notification (sonic-net#695)
[syncd] Use lua script to update db when using bulk api (sonic-net#690)
[syncd] Fix bulk api object type for next hop group members (sonic-net#685)
Add FlexCounter for MACsec SA (sonic-net#684)
AidanCopeland pushed a commit to Metaswitch/sonic-buildimage that referenced this pull request Apr 14, 2022
…t#685)

SAI_OBJECT_TYPE_NEXT_HOP_GROUP_MEMBER object type should be used for m_apis.next_hop_group_api->create_next_hop_group_members

NEXT_HOP_GROUP object type has no bulk api at all
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants