[openconfig_acl] Add SONiC ACL extension to open config ACL model #6896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support for VLAN ID match - Add support for ICMP type/code match Signed-off-by: Danny Allen <daall@microsoft.com>
4 tasks
qiluo-msft
reviewed
Feb 26, 2021
qiluo-msft
approved these changes
Feb 26, 2021
|
openconfig_acl.py seems generated code, can we generate the code during the build? |
I would prefer to merge this as-is to unblock the feature and then refine the process to generate the code at build-time. |
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…nic-net#6896) - Add support for VLAN ID match - Add support for ICMP type/code match Signed-off-by: Danny Allen <daall@microsoft.com>
lolyu
pushed a commit
to lolyu/sonic-buildimage
that referenced
this pull request
Sep 13, 2021
…nic-net#6896) - Add support for VLAN ID match - Add support for ICMP type/code match Signed-off-by: Danny Allen <daall@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danny Allen daall@microsoft.com
Why I did it
To allow users to add ACL rules w/ ICMP and VLAN qualifiers via acl-loader.
How I did it
Added
sonic-acl-extension.yangto augment the existing OpenConfig spec and used pyangbind to generate a new set of python bindings.How to verify it
Re-run the ACL tests w/ the new openconfig_acl.py script and verify that all rules are still loaded properly and dataplane behavior is not impacted.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)