-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix restapi startup #7056
Merged
Merged
fix restapi startup #7056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Good question. The restapi container is still being built upon docker-config-engine-stretch. @prsunny: Is there a reason why it isn't build upon Buster? |
@sumukhatv for viz. @jleveque, @lguohan, we will plan on this and get back. |
do we need this pr as a fix? |
Yes Guohan. We will plan migration to python3 separately |
prsunny
approved these changes
Mar 29, 2021
daall
pushed a commit
that referenced
this pull request
Apr 22, 2021
changed from python3 to python in supervisord.conf.
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
May 23, 2021
changed from python3 to python in supervisord.conf.
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
changed from python3 to python in supervisord.conf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
go-server-server
doesn't start inrestapi
container.restapi
isdocker-config-engine-stretch
base container, and it has noPython3
but onlyPython2
.How I did it
I changed from
python3
topython
insupervisord.conf
.How to verify it
go-server-server
starts inrestapi
container, if specifiedRESTAPI
configs in/etc/sonic/config_db.json
.Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)