Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marvell prestera kernel driver #7066

Merged
merged 3 commits into from
Mar 29, 2021
Merged

Conversation

antony-rheneus
Copy link
Contributor

@antony-rheneus antony-rheneus commented Mar 16, 2021

Build Marvell kernel driver for prestera sai sdk
Builds interrupt and dma kernel driver as part of sonic build

mvIntDrv.ko and mvDmaDrv.ko modules are loaded using etc/modules-load.d/marvell.conf script

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Build Marvell kernel driver for prestera sai sdk
Builds interrupt and dma kernel driver
@lguohan
Copy link
Collaborator

lguohan commented Mar 17, 2021

can you remove replaced kernel driver binary?

@antony-rheneus
Copy link
Contributor Author

can you remove replaced kernel driver binary?

Ok sure, I will remove it, and add as part of this PR too.

Since prestera kernel driver modules are built as part of sonic src
removed the older method pre-compiled kernel module debian package
and its makefile
@antony-rheneus
Copy link
Contributor Author

can you remove replaced kernel driver binary?

Ok sure, I will remove it, and add as part of this PR too.

Done, removed the kernel binary package by removing all its makefile content
Now it is replaced with the prestera.mk which will download the source and build inside sonic buildimage.

@antony-rheneus
Copy link
Contributor Author

retest this please

1 similar comment
@antony-rheneus
Copy link
Contributor Author

retest this please

@antony-rheneus
Copy link
Contributor Author

@lguohan , I hav addressed your comments, on maintaining git tag for the driver source, as well removing old ko binaries from the build.
Would you please review and confirm?

Kernel module download makefiles aree not needed now
Removing those files from repo
@lguohan lguohan merged commit e38e374 into sonic-net:master Mar 29, 2021
@lguohan
Copy link
Collaborator

lguohan commented Mar 29, 2021

can we get this one to 202012 branch?

@antony-rheneus
Copy link
Contributor Author

can we get this one to 202012 branch?

Ok sure, I will port it to 202012 branch.

lguohan pushed a commit that referenced this pull request Mar 31, 2021
Build Marvell kernel driver for prestera sai sdk
Builds interrupt and dma kernel driver
Removed the older method pre-compiled kernel module debian package and its makefile
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request May 23, 2021
Build Marvell kernel driver for prestera sai sdk
Builds interrupt and dma kernel driver
Removed the older method pre-compiled kernel module debian package and its makefile
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
Build Marvell kernel driver for prestera sai sdk
Builds interrupt and dma kernel driver
Removed the older method pre-compiled kernel module debian package and its makefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants