Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[201811][dhcp-relay]: Launch DHCP Relay On L3 Vlan Only #7085

Merged
merged 2 commits into from
May 12, 2021

Conversation

tahmed-dev
Copy link
Contributor

@tahmed-dev tahmed-dev commented Mar 17, 2021

Recent changes brought l2 vlan concept which does not have DHCP
clients behind them and so DHCP relay is not required. Also,
dhcpmon fails to launch on those vlans as their interfaces
lack IP addresses. This PR backposts #6527 that limits launch
of both DHCP relay and dhcpmon to L3 vlans only.

original-pr: #6527
singed-off-by: Tamer Ahmed tamer.ahmed@microsoft.com

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@jleveque jleveque changed the title [dhcp-relay]: Launch DHCP Relay On L3 Vlan (#6527) [201811][dhcp-relay]: Launch DHCP Relay On L3 Vlan (#6527) Mar 19, 2021
@jleveque
Copy link
Contributor

jleveque commented Mar 19, 2021

@tahmed-dev: Can you confirm that this change is already in all upstream branches? I don't see any mention of it in your description.

@jleveque jleveque changed the title [201811][dhcp-relay]: Launch DHCP Relay On L3 Vlan (#6527) [201811][dhcp-relay]: Launch DHCP Relay On L3 Vlan Only (#6527) Mar 19, 2021
@tahmed-dev
Copy link
Contributor Author

@tahmed-dev: Can you confirm that this change is already in all upstream branches? I don't see any mention of it in your description.

@jleveque: it is included in 20201231 and 20191130 branches.

@jleveque
Copy link
Contributor

@tahmed-dev: Can you confirm that this change is already in all upstream branches? I don't see any mention of it in your description.

@jleveque: it is included in 20201231 and 20191130 branches.

Great. And master, I assume?

@tahmed-dev
Copy link
Contributor Author

@tahmed-dev: Can you confirm that this change is already in all upstream branches? I don't see any mention of it in your description.

@jleveque: it is included in 20201231 and 20191130 branches.

Great. And master, I assume?

Yes, it is in master.

@yxieca
Copy link
Contributor

yxieca commented Mar 21, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

2 similar comments
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yxieca
Copy link
Contributor

yxieca commented May 6, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tahmed-dev tahmed-dev force-pushed the taahme/port-dhcp-l2-vlan-fix branch 2 times, most recently from 7ac7e9a to 689545f Compare May 11, 2021 22:42
Recent changes brought l2 vlan concept which does not have DHCP
clients behind them and so DHCP relay is not required. Also,
dhcpmon fails to launch on those vlans as their interfaces
lack IP addresses. This PR limits launch of both DHCP relay
and dhcpmon to L3 vlans only.

singed-off-by: Tamer Ahmed <tamer.ahmed@microsoft.com>
@tahmed-dev tahmed-dev force-pushed the taahme/port-dhcp-l2-vlan-fix branch from 689545f to a8c7f45 Compare May 11, 2021 22:46
@tahmed-dev tahmed-dev changed the title [201811][dhcp-relay]: Launch DHCP Relay On L3 Vlan Only (#6527) [201811][dhcp-relay]: Launch DHCP Relay On L3 Vlan Only May 11, 2021
@tahmed-dev tahmed-dev merged commit cdca8da into sonic-net:201811 May 12, 2021
@tahmed-dev tahmed-dev deleted the taahme/port-dhcp-l2-vlan-fix branch May 12, 2021 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants