Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonic-sairedis] Update submodule #7202

Merged
merged 2 commits into from
Apr 2, 2021
Merged

Conversation

shi-su
Copy link
Contributor

@shi-su shi-su commented Mar 31, 2021

Why I did it

Update the sonic-sairedis submodule. The following is the new commit in the submodule.

1906fdf [pyext] Update Makefile to disable warning Wconversion for older swig (#817)
1dbcaeb Remove gbsyncd_startup.py (#813)
0372615 [vslib] Refresh queue pause status (#814)
00d883c [sairedis] Add sai_dbg_generate_dump api to redis interface (#811)
8585803 [sairedis] Unlock api mutex for communication mode (#812)
c69549a [pyext] Add SWIG sairedis python submodule (#806)

How I did it

Update sonic-sairedis submodule pointer

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

lguohan
lguohan previously approved these changes Mar 31, 2021
@shi-su
Copy link
Contributor Author

shi-su commented Apr 1, 2021

@kcudnik Could you please take a look at the build failure? I think it might relate to sonic-net/sonic-sairedis#806

@kcudnik
Copy link
Contributor

kcudnik commented Apr 1, 2021

pysairedis_wrap.cpp: In function 'int SWIG_AsVal_double(PyObject*, double*)':
pysairedis_wrap.cpp:3474:33: error: conversion to 'double' from 'long int' may alter its value [-Werror=conversion]
     if (val) *val = PyInt_AsLong(obj);
                     ~~~~~~~~~~~~^~~~~
At global scope:
cc1plus: error: unrecognized command line option '-Wno-cast-function-type' [-Werror]

those are 2 errors, conversion and not recognized cast-function-type parameter, this is wired, since build is passing fine on sairedis repo, and on this build here is passing on mellanox and on broadcom - i just chcked brcm and mlnx builds, and it seems like it's not actually building since i dont see logs from sairedis build inside azure pipeline

seems like gcc version used in compiled sonic-buildimage is older than the one used in sonic sairedis

Attempt to fix this: sonic-net/sonic-sairedis#817

@lguohan lguohan merged commit 66216e5 into sonic-net:master Apr 2, 2021
daall pushed a commit that referenced this pull request Apr 2, 2021
1906fdf [pyext] Update Makefile to disable warning Wconversion for older swig (#817)
1dbcaeb Remove gbsyncd_startup.py (#813)
0372615 [vslib] Refresh queue pause status (#814)
00d883c [sairedis] Add sai_dbg_generate_dump api to redis interface (#811)
8585803 [sairedis] Unlock api mutex for communication mode (#812)
c69549a [pyext] Add SWIG sairedis python submodule (#806)
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request May 23, 2021
1906fdf [pyext] Update Makefile to disable warning Wconversion for older swig (sonic-net#817)
1dbcaeb Remove gbsyncd_startup.py (sonic-net#813)
0372615 [vslib] Refresh queue pause status (sonic-net#814)
00d883c [sairedis] Add sai_dbg_generate_dump api to redis interface (sonic-net#811)
8585803 [sairedis] Unlock api mutex for communication mode (sonic-net#812)
c69549a [pyext] Add SWIG sairedis python submodule (sonic-net#806)
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
1906fdf [pyext] Update Makefile to disable warning Wconversion for older swig (sonic-net#817)
1dbcaeb Remove gbsyncd_startup.py (sonic-net#813)
0372615 [vslib] Refresh queue pause status (sonic-net#814)
00d883c [sairedis] Add sai_dbg_generate_dump api to redis interface (sonic-net#811)
8585803 [sairedis] Unlock api mutex for communication mode (sonic-net#812)
c69549a [pyext] Add SWIG sairedis python submodule (sonic-net#806)
@shi-su shi-su deleted the update_sairedis branch August 25, 2021 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants