Provide support for platform hooks in swss.sh #7352
Conversation
| # entry exists in the DEVICE_METADATA table. If it exits then | ||
| # source the script to perform platform specific checks | ||
| PLATFORM_DIR=`sonic-cfggen -H -v DEVICE_METADATA.localhost.platform` | ||
| F="/usr/share/sonic/device/$PLATFORM_DIR/scripts/swss.sh" |
There was a problem hiding this comment.
Does the platform script need to handle stop/wait cases as well ? Another suggestion would be to pass additional parameters like warmboot/fastboot flags, network namespace etc to this script..
|
@VenkatCisco, I have merged a PR #7513 from 201911. This was how we used to parse/extract the PCI-id's from the acis.conf file and populate in DEVICE_METADATA in case of multi-asic platforms. |
HI Judy, as per our earlier review, Guhon & you suggested to use $sonic_asic_platform instead of $PLATFORM_DIR. Accordingly, I have already incorporated those changes in our cisco branch. The diffs are 2 lines as below. F="/usr/share/sonic/device/$sonic_asic_platform/swss.sh" Looks ok, I see that the script platform/cisco-8000/device/cisco-8000/swss.sh updates the pci_ID in DEVICE_METADATA:asic_id. So do we really need a separate script to be invoked from syncd.sh ( #7331) ? |
|
tracked via #7621. |
Why I did it
This is a platform agnostic & vendor agnostic change to files/scripts/swss.sh to check if 'platform' entry exists in the DEVICE_METADATA table. If it exits it checks if there is a file to source and hence does the needful.
How I did it
This is a PR followup from the code-review discussion we had with Guhon/Rita and team. This also addresses one of the comment that was raised to convert to sourcing a file instead of executing the same., so the logic within is run in the same shell.
How to verify it
Verify on the device to ensure any files sourced via the swss.sh hooks are getting executed.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)