[container_checker] Use Feature table to get running containers #7474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ta from "docker ps" 2) Use python-docker for always-enabled
renukamanavalan
requested review from
lguohan,
qiluo-msft,
yozhao101 and
isabelmsft
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
yozhao101
reviewed
Apr 30, 2021
See if it helps with test_monit_status.py failure.
…upport. Hence resort to dockers, if this table is not available.
isabelmsft
reviewed
May 4, 2021
isabelmsft
previously approved these changes
May 5, 2021
yozhao101
reviewed
May 5, 2021
yozhao101
reviewed
May 5, 2021
yozhao101
reviewed
May 5, 2021
yozhao101
reviewed
May 5, 2021
No logical code change.
yozhao101
previously approved these changes
May 6, 2021
yozhao101
reviewed
May 6, 2021
yozhao101
reviewed
May 6, 2021
yozhao101
reviewed
May 6, 2021
yozhao101
previously approved these changes
May 6, 2021
yozhao101
reviewed
May 6, 2021
yozhao101
reviewed
May 6, 2021
yozhao101
approved these changes
May 6, 2021
daall
pushed a commit
that referenced
this pull request
May 10, 2021
Why I did it Finding running containers through "docker ps" breaks when kubernetes deploys container, as the names are mangled. How I did it The data is is available from FEATURE table, which takes care of kubernetes deployment too. How to verify it Deploy a feature via kubernetes and don't expect error from container_check.
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
May 23, 2021
…c-net#7474) Why I did it Finding running containers through "docker ps" breaks when kubernetes deploys container, as the names are mangled. How I did it The data is is available from FEATURE table, which takes care of kubernetes deployment too. How to verify it Deploy a feature via kubernetes and don't expect error from container_check.
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…c-net#7474) Why I did it Finding running containers through "docker ps" breaks when kubernetes deploys container, as the names are mangled. How I did it The data is is available from FEATURE table, which takes care of kubernetes deployment too. How to verify it Deploy a feature via kubernetes and don't expect error from container_check.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Finding running containers through "docker ps" breaks when kubernetes deploys container, as the names are mangled.
How I did it
The data is is available from FEATURE table, which takes care of kubernetes deployment too.
How to verify it
Deploy a feature via kubernetes and don't expect error from container_check.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)