Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DellEMC: Z9332f media settings #7485

Merged
merged 6 commits into from
May 5, 2021

Conversation

aravindmani-1
Copy link
Contributor

Why I did it

Common method is needed to configure pre-emphasis settings in z9332f platform.

How I did it

Changed DellEMC Z9932f media settings from Vendor Name + PN method to common method.

How to verify it

Check APP_DB PORT_TABLE: EthernetX and verify the pre-emphasis settings in NPU.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Description for the changelog

UT:
media_settings_UT.txt

A picture of a cute animal (not mandatory but encouraged)

@srideepDell
Copy link
Contributor

Changes looks good.

@lguohan lguohan merged commit e7db9fe into sonic-net:master May 5, 2021
@lguohan
Copy link
Collaborator

lguohan commented May 5, 2021

does this depends on any other pr?

@aravindmani-1
Copy link
Contributor Author

aravindmani-1 commented May 5, 2021

does this depends on any other pr?
Pre-emphasis settings will work properly only when platform-daemons submodule is updated( with PR: sonic-net/sonic-platform-daemons#177) and #7457 is merged.

@aravindmani-1 aravindmani-1 deleted the Z9332f_media_settings branch May 5, 2021 16:04
daall pushed a commit that referenced this pull request May 10, 2021
Changed DellEMC Z9932f media settings from Vendor Name + PN method to common method.
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request May 23, 2021
Changed DellEMC Z9932f media settings from Vendor Name + PN method to common method.
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
Changed DellEMC Z9932f media settings from Vendor Name + PN method to common method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants