Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Fix build wrapper commands not cleanup issue #7553

Merged
merged 1 commit into from
May 7, 2021

Conversation

xumia
Copy link
Collaborator

@xumia xumia commented May 7, 2021

Why I did it

Need to cleanup the build commands after build finished.

We had a timeout issue where preload firmware:
sonic:~$ sudo /tmp/anpscripts/preload_firmware sonic-aboot-broadcom-20201231.beta.15.swi http://10.20.17.0/firmware/ACS/sonic-aboot-broadcom-20201231.beta.15.swi af124e131bd18e4d66af90935b0d5bac

The timeout is caused by following command started by build command
/usr/bin/curl -Lks http://10.20.17.0/firmware/ACS/sonic-aboot-broadcom-20201231.beta.15.swi | md5sum | cut -d' ' -f1

Why timeout?
It is caused by using the wrong interface, need add "--interface eth0" in curl, it takes more than 1 hours to complete the command if not using the right interface.

sonic:~$ curl -f 'http://10.20.17.0/firmware/ACS/sonic-aboot-broadcom-20201231.beta.15.swi' -o sonic-aboot-broadcom-20201231.beta.15.swi
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  7  974M    7 73.7M    0     0   262k      0  1:03:14  0:04:47  0:58:27  296k

How I did it

Remove the build commands before make the squash fs.

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@xumia xumia requested a review from lguohan as a code owner May 7, 2021 02:30
@xumia xumia requested a review from qiluo-msft May 7, 2021 02:31
@lguohan lguohan merged commit 9daec6f into sonic-net:master May 7, 2021
daall pushed a commit that referenced this pull request May 7, 2021
cleanup the build commands after build finished.
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request May 23, 2021
cleanup the build commands after build finished.
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
cleanup the build commands after build finished.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants