Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[201911][docker-teamd]: Increase teammgrd timeout to allow graceful shutdown #7662

Merged
merged 1 commit into from
May 27, 2021
Merged

[201911][docker-teamd]: Increase teammgrd timeout to allow graceful shutdown #7662

merged 1 commit into from
May 27, 2021

Conversation

nazariig
Copy link
Collaborator

@nazariig nazariig commented May 20, 2021 •
edited
Loading

Signed-off-by: Nazarii Hnydyn nazariig@nvidia.com

Adding a missing part of #6537

Resolves #7591

Why I did it

  • To fix LAG IP configuration race

How I did it

  • Extended timeout for teammgrd

How to verify it

  1. Add >80 router LAGs
  2. Do config reload

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Description for the changelog

  • N/A

A picture of a cute animal (not mandatory but encouraged)

      .---.        .-----------
     /     \  __  /    ------
    / /     \(  )/    -----
   //////   ' \/ `   ---
  //// / // :    : ---
 // /   /  /`    '--
//          //..\\
       ====UU====UU====
           '//||\\`
             ''``

@nazariig
[docker-teamd]: Increase teammgrd timeout to allow graceful shutdown.
395ea2a 
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@nazariig nazariig changed the title [docker-teamd]: Increase teammgrd timeout to allow graceful shutdown [201911][docker-teamd]: Increase teammgrd timeout to allow graceful shutdown May 20, 2021
@liat-grozovik
Copy link
Collaborator

@nazariig can you please explain why this is needed and what is the system behaviour if it is not available?
@lguohan is it by purpose that this PR has no build check?

@lguohan
Copy link
Collaborator

lguohan commented May 20, 2021

i am not aware of. @xumia, @liushilongbuaa , can you check why pr build is not triggered?

@xumia
Copy link
Collaborator

xumia commented May 21, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@prsunny
Copy link
Contributor

prsunny commented May 27, 2021

Discussed with Judy, and request to add teamsyncd changes as a later PR.

@prsunny prsunny merged commit a388b71 into sonic-net:201911 May 27, 2021
@judyjoseph judyjoseph mentioned this pull request Jun 2, 2021
Closed
bingwang-ms pushed a commit to bingwang-ms/sonic-buildimage that referenced this pull request Jun 10, 2021
@nazariig @bingwang-ms
[docker-teamd]: Increase teammgrd timeout to allow graceful shutdown. (…
658ba4e 
…sonic-net#7662)

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@bingwang-ms bingwang-ms mentioned this pull request Jun 10, 2021
Merged
4 tasks
lguohan pushed a commit that referenced this pull request Jun 10, 2021
@bingwang-ms
[docker-teamd]: Increase teammgrd timeout to allow graceful shutdown. (…
c1b380d 
…#7662) (#7842)

The PR is a cherry-pick of #7662.

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request Jun 16, 2021
@nazariig @stepanblyschak
[docker-teamd]: Increase teammgrd timeout to allow graceful shutdown. (…
22b3ecf 
…sonic-net#7662)

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@stepanblyschak stepanblyschak mentioned this pull request Jun 16, 2021
Closed
3 tasks
@stepanblyschak stepanblyschak mentioned this pull request Jul 2, 2021
Merged
3 tasks
liat-grozovik pushed a commit that referenced this pull request Jul 7, 2021
@stepanblyschak
[docker-teamd]: Increase teammgrd timeout to allow graceful shutdown. (…
9dd05bb 
…#7662) (#8045)

NOTE: This is cherry-pick from 1911/2012 to master.

- Why I did it
To fix LAG IP configuration race

- How I did it
Extended timeout for teammgrd

- How to verify it
Add >80 router LAGs. Do config reload

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
judyjoseph pushed a commit that referenced this pull request Jul 13, 2021
@stepanblyschak @judyjoseph
[docker-teamd]: Increase teammgrd timeout to allow graceful shutdown. (…
c200a2a 
…#7662) (#8045)

NOTE: This is cherry-pick from 1911/2012 to master.

- Why I did it
To fix LAG IP configuration race

- How I did it
Extended timeout for teammgrd

- How to verify it
Add >80 router LAGs. Do config reload

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
@stepanblyschak
[docker-teamd]: Increase teammgrd timeout to allow graceful shutdown. (…
fb7dbf9 
…sonic-net#7662) (sonic-net#8045)

NOTE: This is cherry-pick from 1911/2012 to master.

- Why I did it
To fix LAG IP configuration race

- How I did it
Extended timeout for teammgrd

- How to verify it
Add >80 router LAGs. Do config reload

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@judyjoseph judyjoseph judyjoseph left review comments

@liat-grozovik liat-grozovik liat-grozovik approved these changes

@volodymyrsamotiy volodymyrsamotiy Awaiting requested review from volodymyrsamotiy

Assignees
No one assigned
Labels
Bug 🐛 team 👭
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nazariig @liat-grozovik @lguohan @xumia @prsunny @judyjoseph