Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[as5835-54x] Add to support PDDF #7828

Closed

Conversation

jostar-yang
Copy link
Contributor

Signed-off-by: Jostar Yang jostar_yang@accton.com.tw

Why I did it

Add to support PDDF

How I did it

Implement code

How to verify it

Test pddf cmd and sensors cmd.

root@sonic:~# sensors

lm75-i2c-27-4c
Adapter: i2c-2-mux (chan_id 1)
temp1: +29.0 C (high = +84.0 C, hyst = +75.0 C)

psu_pmbus-i2c-12-5b
Adapter: i2c-2-mux (chan_id 2)
in3: +0.00 V
fan1: 200 RPM
power2: 0.00 W
curr2: +0.00 A

psu_pmbus-i2c-11-58
Adapter: i2c-2-mux (chan_id 1)
in3: +11.92 V
fan1: 3000 RPM
power2: 90.00 W
curr2: +7.34 A

acpitz-virtual-0
Adapter: Virtual device
temp1: +0.0 C (crit = +91.0 C)

fan_ctrl-i2c-3-63
Adapter: i2c-1-mux (chan_id 1)
fan1: 11700 RPM
fan2: 9900 RPM
fan3: 11700 RPM
fan4: 9900 RPM
fan5: 11700 RPM
fan6: 9900 RPM
fan7: 11700 RPM
fan8: 9750 RPM
fan9: 11700 RPM
fan10: 9900 RPM

lm75-i2c-28-49
Adapter: i2c-2-mux (chan_id 2)
temp1: +27.5 C (high = +83.0 C, hyst = +75.0 C)

lm75-i2c-26-4b
Adapter: i2c-2-mux (chan_id 0)
temp1: +34.0 C (high = +85.0 C, hyst = +75.0 C)

coretemp-isa-0000
Adapter: ISA adapter
Physical id 0: +40.0 C (high = +71.0 C, crit = +91.0 C)
Core 2: +38.0 C (high = +71.0 C, crit = +91.0 C)
Core 6: +36.0 C (high = +71.0 C, crit = +91.0 C)
Core 8: +39.0 C (high = +71.0 C, crit = +91.0 C)
Core 12: +37.0 C (high = +71.0 C, crit = +91.0 C)

lm75-i2c-29-4a
Adapter: i2c-2-mux (chan_id 3)
temp1: +28.0 C (high = +82.0 C, hyst = +75.0 C)

root@sonic:/home/admin# pddf_psuutil seninfo
PSU1 is OK
Output Voltage: 11906.0 mv
Output Current: 7671.0 ma
Output Power: 97000.0 mw
Fan1 Speed: 3000 rpm

PSU2 is Not OK

root@sonic:/home/admin#
root@sonic:/home/admin# pddf_psuutil mfrinfo
PSU1 is OK
Manufacture Id: 3Y POWER
Model: YM-1401A
Serial Number: SA060V061911000339
Fan Direction: Exhaust

PSU2 is Not OK

root@sonic:/home/admin#
root@sonic:/home/admin#
root@sonic:/home/admin#
root@sonic:/home/admin# pddf_psuutil status
PSU Status


PSU1 OK
PSU2 NOT OK
root@sonic:/home/admin#
root@sonic:/home/admin#
root@sonic:/home/admin#
root@sonic:/home/admin#
root@sonic:/home/admin#
root@sonic:/home/admin# pddf_fanutil status
FAN Status


Fantray1_1 OK
Fantray1_2 OK
Fantray2_1 OK
Fantray2_2 OK
Fantray3_1 OK
Fantray3_2 OK
Fantray4_1 OK
Fantray4_2 OK
Fantray5_1 OK
Fantray5_2 OK

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Jostar Yang <jostar_yang@accton.com.tw>
@lgtm-com
Copy link

lgtm-com bot commented Jun 9, 2021

This pull request introduces 15 alerts when merging 2564453 into f547cad - view on LGTM.com

new alerts:

  • 11 for Unused import
  • 2 for Unused local variable
  • 2 for Use of 'global' at module level

@lgtm-com
Copy link

lgtm-com bot commented Jun 16, 2021

This pull request introduces 1 alert when merging d7dd271 into 9f43598 - view on LGTM.com

new alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Jun 25, 2021

This pull request introduces 1 alert when merging ab15d45 into ef67ba5 - view on LGTM.com

new alerts:

  • 1 for Unused import

@jostar-yang
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

FuzailBrcm
FuzailBrcm previously approved these changes Jul 28, 2021
@lgtm-com
Copy link

lgtm-com bot commented Aug 3, 2021

This pull request introduces 1 alert when merging 2b42ac6 into 93e939b - view on LGTM.com

new alerts:

  • 1 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Sep 29, 2021

This pull request introduces 1 alert when merging a2403e8 into 6cbdf11 - view on LGTM.com

new alerts:

  • 1 for Unused import

@seanwu-ec seanwu-ec mentioned this pull request Dec 28, 2021
5 tasks
FuzailBrcm
FuzailBrcm previously approved these changes Jan 4, 2022
FuzailBrcm
FuzailBrcm previously approved these changes Mar 14, 2022
Copy link
Contributor

@FuzailBrcm FuzailBrcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are fine

@lguohan
Copy link
Collaborator

lguohan commented Mar 18, 2022

can you help to resolve the conflict?

@jostar-yang
Copy link
Contributor Author

/easycla

@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@jostar-yang
Copy link
Contributor Author

Close the PR due to there is esayCLA issue. It can't fix. So create new PR and add new feature to #13700.

@jostar-yang jostar-yang closed this Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants