-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding pre_pddf_init script in the service file #7834
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/AzurePipelines run |
Commenter does not have sufficient privileges for PR 7834 in repo Azure/sonic-buildimage |
/azpw run |
1 similar comment
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
FuzailBrcm
force-pushed
the
pddf_misc_new
branch
from
August 23, 2021 06:20
25a53ef
to
b2b5a04
Compare
This was referenced Aug 23, 2021
babukr
previously approved these changes
Aug 23, 2021
@lguohan pls help review and merge |
FuzailBrcm
force-pushed
the
pddf_misc_new
branch
from
December 17, 2021 07:26
b2b5a04
to
45012bb
Compare
jostar-yang
approved these changes
Dec 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is ok for me.
lguohan
approved these changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Some platforms need to run few steps before the PDDF service is actually started.
How I did it
Added a pre_pddf_init script execution as ExecStartPre in the service file
How to verify it
Verified on AS7816 and AS9716 platforms. Please check
#7826
#7827
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)